Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log for unreferenced file cleanup #11380

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

RS146BIJAY
Copy link
Contributor

@RS146BIJAY RS146BIJAY commented Nov 29, 2023

Description

Adding log for unreferenced file cleanup

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Nov 29, 2023

Compatibility status:

Checks if related components are compatible with change ed6930b

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

✅ Gradle check result for 850991e: SUCCESS

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25cb920) 71.31% compared to head (850991e) 71.35%.
Report is 1 commits behind head on main.

❗ Current head 850991e differs from pull request most recent head ed6930b. Consider uploading reports for the commit ed6930b to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11380      +/-   ##
============================================
+ Coverage     71.31%   71.35%   +0.04%     
- Complexity    58993    59084      +91     
============================================
  Files          4891     4891              
  Lines        277638   277639       +1     
  Branches      40342    40342              
============================================
+ Hits         197995   198120     +125     
+ Misses        63197    63038     -159     
- Partials      16446    16481      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sachinpkale
Copy link
Member

  1. Use imperative mood in PR title
  2. I see all the checklist items are checked even if some are not applicable to this change.

@RS146BIJAY RS146BIJAY changed the title Adding log for unreferenced file cleanup Add log for unreferenced file cleanup Nov 29, 2023
@RS146BIJAY RS146BIJAY force-pushed the guardrail branch 2 times, most recently from f702366 to 1800531 Compare November 29, 2023 10:43
Copy link
Contributor

❌ Gradle check result for f702366: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 1800531: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
Copy link
Contributor

❕ Gradle check result for ed6930b: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimaryMultipleReplicaShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@RS146BIJAY
Copy link
Contributor Author

  1. Use imperative mood in PR title
  2. I see all the checklist items are checked even if some are not applicable to this change.

Changed title. If all the items are not checked, build start failing.

@sachinpkale sachinpkale merged commit 4f7b2a4 into opensearch-project:main Nov 30, 2023
39 of 45 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Nov 30, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 30, 2023
Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
(cherry picked from commit 4f7b2a4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit that referenced this pull request Nov 30, 2023
(cherry picked from commit 4f7b2a4)

Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
fahadshamiinsta pushed a commit to fahadshamiinsta/OpenSearch270 that referenced this pull request Dec 4, 2023
Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Dec 11, 2023
Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: RS146BIJAY <rishavsagar4b1@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants