Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test testThreeNodesNoClusterManagerBlock to retry list #12093

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

kotwanikunal
Copy link
Member

@kotwanikunal kotwanikunal commented Jan 30, 2024

Description

  • Adds testThreeNodesNoClusterManagerBlock to the retry test list
  • The test is noisy and has led to a ton of failures

Related Issues

Related: #10006

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jan 30, 2024

Compatibility status:

Checks if related components are compatible with change ceb5a2f

Incompatible components

Incompatible components: [https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git]

Copy link
Contributor

❕ Gradle check result for e2cfa36: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ed66ae) 71.31% compared to head (ceb5a2f) 71.33%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12093      +/-   ##
============================================
+ Coverage     71.31%   71.33%   +0.02%     
- Complexity    59423    59472      +49     
============================================
  Files          4925     4925              
  Lines        279513   279520       +7     
  Branches      40643    40645       +2     
============================================
+ Hits         199329   199391      +62     
- Misses        63594    63602       +8     
+ Partials      16590    16527      -63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kotwanikunal kotwanikunal added the backport 2.x Backport to 2.x branch label Jan 30, 2024
@kotwanikunal kotwanikunal changed the title Mute flaky test testPrimaryRelocationWhileIndexing Mute flaky test testThreeNodesNoClusterManagerBlock Jan 30, 2024
Copy link
Contributor

❌ Gradle check result for 869c572: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross
Copy link
Member

@kotwanikunal What do you think about muting versus adding it to the retry list? Neither option is good, but for a flaky test like this that is likely to pass on a retry it seems a little less severe than just muting it.

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
@kotwanikunal kotwanikunal changed the title Mute flaky test testThreeNodesNoClusterManagerBlock Add test testThreeNodesNoClusterManagerBlock to retry list Jan 31, 2024
Copy link
Contributor

❕ Gradle check result for ceb5a2f: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@andrross andrross merged commit 90a815e into opensearch-project:main Feb 2, 2024
36 of 38 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 2, 2024
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
(cherry picked from commit 90a815e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Feb 2, 2024
(cherry picked from commit 90a815e)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
@kotwanikunal kotwanikunal deleted the mute-10006 branch April 9, 2024 23:08
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ct#12093)

Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants