Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix FuzzyFilterPostingsFormatTests] Suppress sys out checks for test case #13188

Merged
merged 1 commit into from
Apr 16, 2024
Merged

[Fix FuzzyFilterPostingsFormatTests] Suppress sys out checks for test case #13188

merged 1 commit into from
Apr 16, 2024

Conversation

mgodwan
Copy link
Member

@mgodwan mgodwan commented Apr 15, 2024

…failures

Description

[Fix FuzzyFilterPostingsFormatTests] Suppress sys out checks for test case

Related Issues

Resolves #13177

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mgodwan
Suppress sys out checks as trace logs enabled during tests can cause …
75a824d 
…failures

Signed-off-by: mgodwan <mgodwan@amazon.com>
@github-actions github-actions bot added bug Something isn't working flaky-test Random test failure that succeeds on second run Indexing Indexing, Bulk Indexing and anything related to indexing Other labels Apr 15, 2024
@mgodwan mgodwan marked this pull request as ready for review April 15, 2024 07:25
@mgodwan mgodwan requested a review from VachaShah as a code owner April 15, 2024 07:25
@github-actions GitHub Actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 75a824d

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 75a824d: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.60%. Comparing base (b15cb0c) to head (75a824d).
Report is 161 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #13188      +/-   ##
============================================
+ Coverage     71.42%   71.60%   +0.18%     
- Complexity    59978    60755     +777     
============================================
  Files          4985     5039      +54     
  Lines        282275   285338    +3063     
  Branches      40946    41327     +381     
============================================
+ Hits         201603   204320    +2717     
- Misses        63999    64147     +148     
- Partials      16673    16871     +198

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

owaiskazi19
owaiskazi19 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @mgodwan

@shwetathareja shwetathareja merged commit 3e8e116 into opensearch-project:main Apr 16, 2024
85 of 86 checks passed
@mgodwan mgodwan added the backport 2.x Backport to 2.x branch label Apr 16, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 16, 2024
@github-actions
Suppress sys out checks as trace logs enabled during tests can cause …
71f9d08 
…failures (#13188)

Signed-off-by: mgodwan <mgodwan@amazon.com>
(cherry picked from commit 3e8e116)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 16, 2024
Merged
dblock pushed a commit that referenced this pull request Apr 16, 2024
@opensearch-trigger-bot @github-actions
Suppress sys out checks as trace logs enabled during tests can cause …
5f8ffee 
…failures (#13188) (#13231)

(cherry picked from commit 3e8e116)

Signed-off-by: mgodwan <mgodwan@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwetathareja shwetathareja shwetathareja approved these changes

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch bug Something isn't working flaky-test Random test failure that succeeds on second run Indexing Indexing, Bulk Indexing and anything related to indexing Other skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.index.codec.fuzzy.FuzzyFilterPostingsFormatTests is flaky
3 participants
@mgodwan @shwetathareja @owaiskazi19