Handle shard allocation for NONE migration direction

[ltaragi]

Description

• Before migration starts, new nodes join the cluster in MIXED compatibility mode, while the migration direction remains at its default value of NONE.
• We should handle shard allocation correctly under these conditions, based on the index settings.
• This change handles the following scenarios in RemoteStoreMigrationAllocationDecider.java:
  • For remote store backed indices, shards should only be allocated to remote store nodes.
  • For non remote store backed indices, shards should only be allocated to non-remote store or docrep nodes.
• Extends validation for TranslogDurabilitySettings to the case of remote store migration by adding extra condition of isMigratingToRemoteStore(clusterSettings) == false here

Related Issues

Resolves #13321

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 9a87afe: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for e361cf1: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 70.81%. Comparing base (b15cb0c) to head (54bfe73).
Report is 245 commits behind head on main.

Files	Patch %	Lines
...decider/RemoteStoreMigrationAllocationDecider.java	62.50%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13322      +/-   ##
============================================
- Coverage     71.42%   70.81%   -0.61%     
- Complexity    59978    60325     +347     
============================================
  Files          4985     5050      +65     
  Lines        282275   286807    +4532     
  Branches      40946    41553     +607     
============================================
+ Hits         201603   203111    +1508     
- Misses        63999    66739    +2740     
- Partials      16673    16957     +284     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

❕ Gradle check result for 82c963f: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteLargeBlob

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

❌ Gradle check result for 9033742: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 8a5ef58: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❕ Gradle check result for 54bfe73: UNSTABLE

• TEST FAILURES:

      2 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.classMethod
      1 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.testResizeQueueDown

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[ltaragi]

❕ Gradle check result for 54bfe73: UNSTABLE

• TEST FAILURES:

      2 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.classMethod
      1 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.testResizeQueueDown

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Flaky test #11979