Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more identifiers to gradle-check job webhook payload #13714

Merged
merged 1 commit into from
May 16, 2024

Conversation

rishabh6788
Copy link
Contributor

@rishabh6788 rishabh6788 commented May 16, 2024

Description

Fixes the revert in #13027.
Solution proposed in #13025 (comment)
From my test run I can confirm that pr description now does not contains new lines, the new line character is now escaped.
Sample run and output https://github.com/rishabh6788/OpenSearch/actions/runs/9117260498/job/25067702370.

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rishabh Singh <sngri@amazon.com>
@rishabh6788
Copy link
Contributor Author

@dblock Do you ming taking a look at it again?

Copy link
Contributor

❌ Gradle check result for 7c79941: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rishabh6788
Copy link
Contributor Author

❌ Gradle check result for 7c79941: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

#9464

Copy link
Contributor

❌ Gradle check result for 7c79941: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rishabh6788
Copy link
Contributor Author

rishabh6788 commented May 16, 2024

❌ Gradle check result for 7c79941: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky tests https://github.com/opensearch-project/OpenSearch/issues?q=is%3Aissue+is%3Aopen+IndicesRequestCacheIT.

@github-actions github-actions bot added >test-failure Test failure from CI, local build, etc. backport 2.1 backport 2.2 Backport to 2.2 branch backport 2.3 Backports to 2.3 branch backport 2.x Backport to 2.x branch bug Something isn't working Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. v3.0.0 Issues and PRs related to version 3.0.0 labels May 16, 2024
Copy link
Contributor

✅ Gradle check result for 7c79941: SUCCESS

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.55%. Comparing base (b15cb0c) to head (7c79941).
Report is 288 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13714      +/-   ##
============================================
+ Coverage     71.42%   71.55%   +0.13%     
- Complexity    59978    61232    +1254     
============================================
  Files          4985     5060      +75     
  Lines        282275   287854    +5579     
  Branches      40946    41689     +743     
============================================
+ Hits         201603   205973    +4370     
- Misses        63999    64868     +869     
- Partials      16673    17013     +340     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied peternied merged commit 4700be3 into opensearch-project:main May 16, 2024
41 of 49 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 16, 2024
(cherry picked from commit 4700be3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.1 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.1 2.1
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.1
# Create a new branch
git switch --create backport/backport-13714-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4700be3e72e9193d438718120d1228222785786c
# Push it to GitHub
git push --set-upstream origin backport/backport-13714-to-2.1
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.1

Then, create a pull request where the base branch is 2.1 and the compare/head branch is backport/backport-13714-to-2.1.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.2 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.2 2.2
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.2
# Create a new branch
git switch --create backport/backport-13714-to-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4700be3e72e9193d438718120d1228222785786c
# Push it to GitHub
git push --set-upstream origin backport/backport-13714-to-2.2
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.2

Then, create a pull request where the base branch is 2.2 and the compare/head branch is backport/backport-13714-to-2.2.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.3 2.3
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.3
# Create a new branch
git switch --create backport/backport-13714-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4700be3e72e9193d438718120d1228222785786c
# Push it to GitHub
git push --set-upstream origin backport/backport-13714-to-2.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.3

Then, create a pull request where the base branch is 2.3 and the compare/head branch is backport/backport-13714-to-2.3.

@peternied peternied removed backport 2.x Backport to 2.x branch backport 2.1 backport 2.2 Backport to 2.2 branch backport 2.3 Backports to 2.3 branch labels May 17, 2024
@peternied peternied added the backport 2.x Backport to 2.x branch label May 17, 2024
@peternied
Copy link
Member

peternied commented May 17, 2024

@rishabh6788 It looks like this had a number of backports targets labeled, IMO the only backport that should be applied is to 2.x which I have just merged.

This still track for you?

@opensearch-trigger-bot

This comment was marked as resolved.

peternied pushed a commit that referenced this pull request May 17, 2024
…3722)

(cherry picked from commit 4700be3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@rishabh6788
Copy link
Contributor Author

@rishabh6788 It looks like this had a number of backports targets labeled, IMO the only backport that should be applied is to 2.x which I have just merged.

This still track for you?

Agree with only 2.x back-port label. Not sure why the bot applied those labels.
Do not need those extra back-ports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed bug Something isn't working Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. skip-changelog >test-failure Test failure from CI, local build, etc. v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
2 participants