Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Adds latency metrics for ClusterState Appliers and Listeners #13755

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport a254aa9 from #12333.

* Adds latency metrics for ClusterState Appliers and Listeners

Signed-off-by: Harsh Garg <gkharsh@amazon.com>
(cherry picked from commit a254aa9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❕ Gradle check result for 6d23c1d: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testCancellation

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@mch2
Copy link
Member

mch2 commented May 20, 2024

Detect breaking changes workflow is correctly catching an issue here - This breaks the ctor for ClusterService which is marked as api - ex. https://github.com/opensearch-project/asynchronous-search/pull/576/files

@shwetathareja
Copy link
Member

Detect breaking changes workflow is correctly catching an issue here - This breaks the ctor for ClusterService which is marked as api - ex. https://github.com/opensearch-project/asynchronous-search/pull/576/files

@mch2 ClusterService, MasterService, AllocationService, for all these classes singleton objects are created in Node.java and then injected all throughout. How do you suggest we can handle constructor changes here?

@opensearch-trigger-bot
Copy link
Contributor Author

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Jun 26, 2024
@mch2
Copy link
Member

mch2 commented Jun 26, 2024

Detect breaking changes workflow is correctly catching an issue here - This breaks the ctor for ClusterService which is marked as api - ex. https://github.com/opensearch-project/asynchronous-search/pull/576/files

@mch2 ClusterService, MasterService, AllocationService, for all these classes singleton objects are created in Node.java and then injected all throughout. How do you suggest we can handle constructor changes here?

apologies @shwetathareja for the late reply - seems this has been resolved with overloading the ctors in #13926. I think we can merge this backport with a rebase?

@gargharsh3134
Copy link
Contributor

Another backport PR was merged to address this (#14118).
This PR is no longer required and can be closed.

@dbwiddis dbwiddis deleted the backport/backport-12333-to-2.x branch July 24, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants