Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Query insights exporters implementation (#12982) #14061

Merged

Conversation

ansjcy
Copy link
Member

@ansjcy ansjcy commented Jun 7, 2024

Original PR: #12982

Signed-off-by: Chenyang Ji cyji@amazon.com
(cherry picked from commit 0ddf4bd)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for 65cf9d2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for 65cf9d2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 7, 2024

❌ Gradle check result for 65cf9d2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

---------

Signed-off-by: Chenyang Ji <cyji@amazon.com>
(cherry picked from commit 0ddf4bd)
@ansjcy ansjcy force-pushed the backport/backport-12982-to-2.x branch from 65cf9d2 to d2f2896 Compare June 7, 2024 17:21
Copy link
Contributor

github-actions bot commented Jun 7, 2024

❕ Gradle check result for d2f2896: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 66.91176% with 45 lines in your changes missing coverage. Please review.

Project coverage is 71.24%. Comparing base (0dd892c) to head (d2f2896).
Report is 314 commits behind head on 2.x.

Files Patch % Lines
...lugin/insights/core/service/TopQueriesService.java 23.33% 22 Missing and 1 partial ⚠️
...ts/core/exporter/QueryInsightsExporterFactory.java 74.41% 8 Missing and 3 partials ⚠️
...gin/insights/core/exporter/LocalIndexExporter.java 77.77% 5 Missing and 1 partial ⚠️
...search/plugin/insights/core/exporter/SinkType.java 75.00% 3 Missing ⚠️
...in/insights/core/service/QueryInsightsService.java 83.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14061      +/-   ##
============================================
- Coverage     71.28%   71.24%   -0.05%     
- Complexity    60145    61435    +1290     
============================================
  Files          4957     5045      +88     
  Lines        282799   289011    +6212     
  Branches      41409    42210     +801     
============================================
+ Hits         201591   205898    +4307     
- Misses        64189    65721    +1532     
- Partials      17019    17392     +373     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jed326 jed326 merged commit d2da9bb into opensearch-project:2.x Jun 7, 2024
30 of 31 checks passed
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…pensearch-project#14061)

---------

Signed-off-by: Chenyang Ji <cyji@amazon.com>
(cherry picked from commit 0ddf4bd)
Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants