[Remote Store] Rate limiter for low priority uploads #14374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
gbbafna
added
backport 2.x
github-actions
bot
added
enhancement
shourya035
reviewed
Jun 15, 2024
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Outdated
Show resolved
Hide resolved
|
❕ Gradle check result for 913b742: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14374 +/- ##
============================================
+ Coverage 71.42% 71.76% +0.34%
- Complexity 59978 62114 +2136
============================================
Files 4985 5118 +133
Lines 282275 291845 +9570
Branches 40946 42189 +1243
============================================
+ Hits 201603 209451 +7848
- Misses 63999 65094 +1095
- Partials 16673 17300 +627 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
gbbafna
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
kotwanikunal,
mch2,
msfroh,
nknize and
owaiskazi19
as code owners
gbbafna
requested review from
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
sachinpkale
reviewed
Jun 18, 2024
server/src/main/java/org/opensearch/repositories/blobstore/BlobStoreRepository.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/repositories/Repository.java
Outdated
Show resolved
Hide resolved
.../internalClusterTest/java/org/opensearch/action/admin/indices/create/RemoteCloneIndexIT.java
Show resolved
Hide resolved
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
|
❕ Gradle check result for aebb7c6: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
sachinpkale
approved these changes
Jun 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 18, 2024
--------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit e22b651) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna
pushed a commit
that referenced
this pull request
Jun 19, 2024
--------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit e22b651) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Jul 12, 2024
…ect#14374) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…ect#14374) (opensearch-project#14421) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit e22b651) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…ect#14374) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have rate limiter for remote uploads . However we don't have a way to control the low priority upload . In absence of this, our rate limits both high priority as well as low priority uploads. We introduce Rate limiter for low priority uploads to solve this.
Related Issues
Resolves #14373
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.