Add javadoc about ThreadContextPermission for stashWithOrigin and stashAndMergeHeaders #15051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shAndMergeHeaders Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
@reta Can we add skip-changelog to this PR? I don't think it needs a CHANGELOG entry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15051 +/- ##
============================================
- Coverage 71.90% 71.88% -0.03%
+ Complexity 62828 62820 -8
============================================
Files 5169 5169
Lines 294645 294645
Branches 42610 42610
============================================
- Hits 211869 211809 -60
- Misses 65343 65459 +116
+ Partials 17433 17377 -56 ☔ View full report in Codecov by Sentry. |
reta
approved these changes
Aug 1, 2024
reta
pushed a commit
that referenced
this pull request
Aug 1, 2024
…shAndMergeHeaders (#15051) (#15055) (cherry picked from commit 67a2e4c) Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Aug 20, 2024
…shAndMergeHeaders (opensearch-project#15051) Signed-off-by: Craig Perkins <cwperx@amazon.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…shAndMergeHeaders (opensearch-project#15051) Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #15039 to add javadoc on the permissions added to ThreadContext.stashWithOrigin and ThreadContext.stashAndMergeHeaders
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.