Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not throw exception when flat_object field is explicitly null #15431

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Do not throw exception when flat_object field is explicitly null #15431

merged 1 commit into from
Aug 27, 2024

Commits on Aug 26, 2024

  1. Do not throw exception when flat_object field is explicitly null (#15375 

    )

It is valid for a flat_object field to have an explicit value of
null. (It's functionally the same as not specifying the field at
all.) Prior to this fix, though, we would erroneously advance the
context parser to the next token, violating the contract with
DocumentParser (which says that a call to parseCreateField with
a null value should complete with the parser still pointing at
the null value -- it is DocumentParser's responsibility to advance).

Signed-off-by: Michael Froh <froh@amazon.com>

* Fix unit test

Signed-off-by: Michael Froh <froh@amazon.com>

* Add changelog entry

Signed-off-by: Michael Froh <froh@amazon.com>

---------

Signed-off-by: Michael Froh <froh@amazon.com>
(cherry picked from commit 46a269e)
    @msfroh
    msfroh committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8416faa View commit details
    Browse the repository at this point in the history