-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow RemotePublication configured nodes to join remote cluster in mixed mode #15994
base: main
Are you sure you want to change the base?
Allow RemotePublication configured nodes to join remote cluster in mixed mode #15994
Conversation
844b9d5
to
c3c4627
Compare
❌ Gradle check result for 844b9d5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for c3c4627: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
c3c4627
to
aaa0719
Compare
❌ Gradle check result for aaa0719: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
aaa0719
to
78306e7
Compare
❕ Gradle check result for 78306e7: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15994 +/- ##
============================================
+ Coverage 71.90% 71.98% +0.07%
+ Complexity 64392 64323 -69
============================================
Files 5278 5280 +2
Lines 300877 300877
Branches 43478 43478
============================================
+ Hits 216351 216578 +227
+ Misses 66747 66537 -210
+ Partials 17779 17762 -17 ☔ View full report in Codecov by Sentry. |
78306e7
to
813322a
Compare
❌ Gradle check result for 813322a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
813322a
to
ba4a52a
Compare
❌ Gradle check result for ba4a52a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
ba4a52a
to
5e8295c
Compare
❌ Gradle check result for 5e8295c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
Currently in MIXED compatibility mode, a non-remote node of same version can join the Remote cluster. On similar lines, this fix allows node with RemotePublication repositories configured to join Remote cluster in MIXED mode.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.