Add 'cluster_manager_node' into ClusterState Metric as an alternative to 'master_node' #2415

tlfeng · 2022-03-09T00:49:06Z

Description

Add cluster_manager_node into ClusterState Metric, as an alternative to master_node. So that the request parameter "metric" in Cluster reroute and Cluster state API accept the new value cluster_manager_node
Deprecate the enum value of Metric: MASTER_NODE("master_node")
Add YAML REST tests for the new parameter value for "cluster state" and "cluster reroute" API

Note: the metric value "master_node" will be removed in a future major version.

Current API response:

curl http://localhost:9200/_cluster/state
{
    "cluster_name": "runTask",
    "cluster_uuid": "sRUtNoElRZabqI6IzrbuDA",
    "version": 1,
    "state_uuid": "aFdad3DLR0uXa5I5KurWGw",
    "master_node": "8e14Q8K2Ro6wpSq8Sn8c9Q",
    "blocks": {
...
}

curl http://localhost:9200/_cluster/state?metric=master_node
{
    "cluster_name": "runTask",
    "cluster_uuid": "sRUtNoElRZabqI6IzrbuDA",
    "master_node": "8e14Q8K2Ro6wpSq8Sn8c9Q"
}

curl -XPOST http://localhost:9200/_cluster/reroute
{
    "acknowledged": true,
    "state": {
        "cluster_uuid": "x8bf0r1aRde0z0c5tza8uQ",
        "version": 5,
        "state_uuid": "l4ZaW_X_QBKuR5hm2LtCwA",
        "master_node": "2RlN3y_GQBa4B_hvR5oxJA",
        "blocks": {},
...
    }
}

curl -XPOST http://localhost:9200/_cluster/reroute?metric=master_node
{
    "acknowledged": true,
    "state": {
        "cluster_uuid": "x8bf0r1aRde0z0c5tza8uQ",
        "master_node": "2RlN3y_GQBa4B_hvR5oxJA"
    }
}

Proposed API response:

curl http://localhost:9200/_cluster/state
{
    "cluster_name": "runTask",
    "cluster_uuid": "sRUtNoElRZabqI6IzrbuDA",
    "version": 1,
    "state_uuid": "aFdad3DLR0uXa5I5KurWGw",
    "master_node": "8e14Q8K2Ro6wpSq8Sn8c9Q",
    "cluster_manager_node": "8e14Q8K2Ro6wpSq8Sn8c9Q",
    "blocks": {
...
}

curl http://localhost:9200/_cluster/state?metric=cluster_manager_node
{
    "cluster_name": "runTask",
    "cluster_uuid": "i8moBzDRRSiz6oX3et_NTQ",
    "cluster_manager_node": "ehHOzYlaQoS5XhX1A8P12g"
}

curl http://localhost:9200/_cluster/state?metric=cluster_manager_node,master_node
{
    "cluster_name": "runTask",
    "cluster_uuid": "sRUtNoElRZabqI6IzrbuDA",
    "master_node": "8e14Q8K2Ro6wpSq8Sn8c9Q",
    "cluster_manager_node": "8e14Q8K2Ro6wpSq8Sn8c9Q"
}

curl -XPOST http://localhost:9200/_cluster/reroute
{
    "acknowledged": true,
    "state": {
        "cluster_uuid": "x8bf0r1aRde0z0c5tza8uQ",
        "version": 5,
        "state_uuid": "l4ZaW_X_QBKuR5hm2LtCwA",
        "master_node": "2RlN3y_GQBa4B_hvR5oxJA",
        "cluster_manager_node": "2RlN3y_GQBa4B_hvR5oxJA",
        "blocks": {},
...
    }
}

curl -XPOST http://localhost:9200/_cluster/reroute?metric=cluster_manager_node
{
    "acknowledged": true,
    "state": {
        "cluster_uuid": "x8bf0r1aRde0z0c5tza8uQ",
        "cluster_manager_node": "2RlN3y_GQBa4B_hvR5oxJA"
    }
}

curl -XPOST http://localhost:9200/_cluster/reroute?metric=master_node,cluster_manager_node
{
    "acknowledged": true,
    "state": {
        "cluster_uuid": "x8bf0r1aRde0z0c5tza8uQ",
        "master_node": "2RlN3y_GQBa4B_hvR5oxJA",
        "cluster_manager_node": "2RlN3y_GQBa4B_hvR5oxJA"
    }
}

Testing:

./gradlew ':rest-api-spec:yamlRestTest' \
  --tests "org.opensearch.test.rest.ClientYamlTestSuiteIT" \
  -Dtests.method="test {p0=cluster.state/10_basic/*}"

./gradlew ':rest-api-spec:yamlRestTest' \
  --tests "org.opensearch.test.rest.ClientYamlTestSuiteIT" \
  -Dtests.method="test {p0=cluster.state/20_filtering/*}"

  ./gradlew ':rest-api-spec:yamlRestTest' \
  --tests "org.opensearch.test.rest.ClientYamlTestSuiteIT" \
  -Dtests.method="test {p0=cluster.reroute/10_basic/*}"

./gradlew ':rest-api-spec:yamlRestTest' \
  --tests "org.opensearch.test.rest.ClientYamlTestSuiteIT" \
  -Dtests.method="test {p0=cluster.reroute/20_response_filtering/*}"

Issues Resolved

Part of #1549

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tianli Feng <ftianli@amazon.com>

opensearch-ci-bot · 2022-03-09T00:50:02Z

Can one of the admins verify this patch?

Signed-off-by: Tianli Feng <ftianli@amazon.com>

opensearch-ci-bot · 2022-03-09T01:16:47Z

❌ Gradle Check failure c73c35c
Log 3191

Reports 3191

opensearch-ci-bot · 2022-03-09T01:32:41Z

❌ Gradle Check failure e8dbdf2
Log 3193

Reports 3193

Signed-off-by: Tianli Feng <ftianli@amazon.com>

opensearch-ci-bot · 2022-03-09T03:52:47Z

❌ Gradle Check failure 9bc6994
Log 3195

Reports 3195

tlfeng · 2022-03-09T03:55:53Z

In Log 3195:

> Task :server:internalClusterTest

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.discovery.StableMasterDisruptionIT.testStaleMasterNotHijackingMajority" -Dtests.seed=FDC85C1C2E6AEAE4 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=zh-Hans-CN -Dtests.timezone=Pacific/Majuro -Druntime.java=17

org.opensearch.discovery.StableMasterDisruptionIT > testStaleMasterNotHijackingMajority FAILED
    java.lang.AssertionError: node_t2: [Tuple [v1=node_t0, v2=null]]
        at __randomizedtesting.SeedInfo.seed([FDC85C1C2E6AEAE4:A2CE11130FB135E8]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.opensearch.discovery.StableMasterDisruptionIT.lambda$testStaleMasterNotHijackingMajority$5(StableMasterDisruptionIT.java:253)
        at org.opensearch.test.OpenSearchTestCase.assertBusy(OpenSearchTestCase.java:1060)
        at org.opensearch.test.OpenSearchTestCase.assertBusy(OpenSearchTestCase.java:1033)
        at org.opensearch.discovery.StableMasterDisruptionIT.testStaleMasterNotHijackingMajority(StableMasterDisruptionIT.java:250)

It's reported in issue #1565, and can't be reproduced locally.

tlfeng · 2022-03-09T04:14:19Z

start gradle check

opensearch-ci-bot · 2022-03-09T04:37:44Z

❌ Gradle Check failure 9bc6994
Log 3196

Reports 3196

tlfeng · 2022-03-09T17:35:55Z

In log 3196:

> Task :qa:full-cluster-restart:v1.3.0#oldClusterTest

REPRODUCE WITH: ./gradlew ':qa:full-cluster-restart:v1.3.0#oldClusterTest' --tests "org.opensearch.upgrades.FullClusterRestartIT.testEmptyShard" -Dtests.seed=139C64E25A2E9B3C -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=zh-Hant-TW -Dtests.timezone=Africa/Tripoli -Druntime.java=17

org.opensearch.upgrades.FullClusterRestartIT > testEmptyShard FAILED
    org.opensearch.client.WarningFailureException: method [PUT], host [http://[::1]:33663], URI [/test_empty_shard], status line [HTTP/1.1 200 OK]
    {"acknowledged":true,"shards_acknowledged":true,"index":"test_empty_shard"}
        at __randomizedtesting.SeedInfo.seed([139C64E25A2E9B3C:5FE7B33AA617B4A9]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:346)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:295)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:976)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:956)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:952)
        at app//org.opensearch.upgrades.FullClusterRestartIT.testEmptyShard(FullClusterRestartIT.java:670)

It's reported in issue #2359, and not reproducible locally.

opensearch-ci-bot · 2022-03-09T18:39:55Z

❌ Gradle Check failure 56b77a78705bebe6714482c1544041971e0456f6
Log 3200

Reports 3200

Signed-off-by: Tianli Feng <ftl94@live.com>

tlfeng · 2022-03-09T19:22:47Z

In log 3200:

> Task :server:internalClusterTest

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.gateway.RecoveryFromGatewayIT.testReuseInFileBasedPeerRecovery" -Dtests.seed=EC2AC32E15B83B10 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=uk -Dtests.timezone=Asia/Yerevan -Druntime.java=17

org.opensearch.gateway.RecoveryFromGatewayIT > testReuseInFileBasedPeerRecovery FAILED
    java.lang.AssertionError: shard [test][0] on node [node_t1] has pending operations:
     --> RetentionLeaseBackgroundSyncAction.Request{retentionLeases=RetentionLeases{primaryTerm=1, version=1639, leases={peer_recovery/0nZoCPTuR9y-pPHUyWAAog=RetentionLease{id='peer_recovery/0nZoCPTuR9y-pPHUyWAAog', retainingSequenceNumber=809, timestamp=1646850484326, source='peer recovery'}, peer_recovery/LJf9Uw5ZQfyi44Lqns5Lvg=RetentionLease{id='peer_recovery/LJf9Uw5ZQfyi44Lqns5Lvg', retainingSequenceNumber=809, timestamp=1646850484326, source='peer recovery'}}}, shardId=[test][0], timeout=1m, index='test', waitForActiveShards=0}
    	at org.opensearch.index.shard.IndexShardOperationPermits.acquire(IndexShardOperationPermits.java:248)
    	at org.opensearch.index.shard.IndexShard.acquirePrimaryOperationPermit(IndexShard.java:3207)
...

It's reported in issue #1746, and isn't reproducible locally.

opensearch-ci-bot · 2022-03-09T20:08:28Z

✅ Gradle Check success d2c177a
Log 3201

Reports 3201

Signed-off-by: Tianli Feng <ftianli@amazon.com>

opensearch-ci-bot · 2022-03-13T07:45:20Z

❌ Gradle Check failure d579487
Log 3311

Reports 3311

opensearch-ci-bot · 2022-03-13T08:12:39Z

❌ Gradle Check failure 0d66c0c
Log 3314

Reports 3314

tlfeng · 2022-03-14T04:33:21Z

In log 3314:

> Task :rest-api-spec:yamlRestTest

REPRODUCE WITH: ./gradlew ':rest-api-spec:yamlRestTest' --tests "org.opensearch.test.rest.ClientYamlTestSuiteIT" -Dtests.method="test {p0=cluster.state/20_filtering/Filtering the cluster state returns cluster_uuid at the top level regardless of metric filters}" -Dtests.seed=F231651D93AD15B9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=be-BY -Dtests.timezone=US/Michigan -Druntime.java=17

org.opensearch.test.rest.ClientYamlTestSuiteIT > test {p0=cluster.state/20_filtering/Filtering the cluster state returns cluster_uuid at the top level regardless of metric filters} FAILED
    java.lang.AssertionError: Failure at [cluster.state/20_filtering:167]: got unexpected warning header [
    	299 OpenSearch-2.0.0-SNAPSHOT-39bb32cda160d58fa657f30d2c6e0873d1ca9fd0 "Deprecated value [master_node] used for parameter [metric]. To promote inclusive language, please use [cluster_manager_node] instead. It will be unsupported in a future major version."
    ]
        at __randomizedtesting.SeedInfo.seed([F231651D93AD15B9:7A655AC73D517841]:0)
        at org.opensearch.test.rest.yaml.OpenSearchClientYamlSuiteTestCase.executeSection(OpenSearchClientYamlSuiteTestCase.java:442)
        at org.opensearch.test.rest.yaml.OpenSearchClientYamlSuiteTestCase.test(OpenSearchClientYamlSuiteTestCase.java:415)

> Task :qa:smoke-test-multinode:integTest

REPRODUCE WITH: ./gradlew ':qa:smoke-test-multinode:integTest' --tests "org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT" -Dtests.method="test {yaml=cluster.state/20_filtering/Filtering the cluster state using _all for indices and metrics should work}" -Dtests.seed=F231651D93AD15B9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=hu-HU -Dtests.timezone=America/Jamaica -Druntime.java=17

org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT > test {yaml=cluster.state/20_filtering/Filtering the cluster state using _all for indices and metrics should work} FAILED
    java.lang.AssertionError: Failure at [cluster.state/20_filtering:116]: got unexpected warning header [
    	299 OpenSearch-2.0.0-SNAPSHOT-39bb32cda160d58fa657f30d2c6e0873d1ca9fd0 "Deprecated value [master_node] used for parameter [metric]. To promote inclusive language, please use [cluster_manager_node] instead. It will be unsupported in a future major version."
    ]
        at __randomizedtesting.SeedInfo.seed([F231651D93AD15B9:7A655AC73D517841]:0)
        at org.opensearch.test.rest.yaml.OpenSearchClientYamlSuiteTestCase.executeSection(OpenSearchClientYamlSuiteTestCase.java:442)
        at org.opensearch.test.rest.yaml.OpenSearchClientYamlSuiteTestCase.test(OpenSearchClientYamlSuiteTestCase.java:415)

> Task :qa:mixed-cluster:v1.3.0#mixedClusterTest

REPRODUCE WITH: ./gradlew ':qa:mixed-cluster:v1.3.0#mixedClusterTest' --tests "org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT" -Dtests.method="test {p0=cluster.state/20_filtering/Filtering the cluster state returns cluster_uuid at the top level regardless of metric filters}" -Dtests.seed=F231651D93AD15B9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=he -Dtests.timezone=Poland -Druntime.java=17

org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT > test {p0=cluster.state/20_filtering/Filtering the cluster state returns cluster_uuid at the top level regardless of metric filters} FAILED
    java.lang.AssertionError: Failure at [cluster.state/20_filtering:167]: got unexpected warning header [
    	299 OpenSearch-2.0.0-SNAPSHOT-39bb32cda160d58fa657f30d2c6e0873d1ca9fd0 "Deprecated value [master_node] used for parameter [metric]. To promote inclusive language, please use [cluster_manager_node] instead. It will be unsupported in a future major version."
    ]
        at __randomizedtesting.SeedInfo.seed([F231651D93AD15B9:7A655AC73D517841]:0)
        at org.opensearch.test.rest.yaml.OpenSearchClientYamlSuiteTestCase.executeSection(OpenSearchClientYamlSuiteTestCase.java:442)
        at org.opensearch.test.rest.yaml.OpenSearchClientYamlSuiteTestCase.test(OpenSearchClientYamlSuiteTestCase.java:415)
...

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.indices.recovery.IndexRecoveryIT.testRerouteRecovery" -Dtests.seed=F231651D93AD15B9 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-PY -Dtests.timezone=Africa/Mogadishu -Druntime.java=17

org.opensearch.indices.recovery.IndexRecoveryIT > testRerouteRecovery FAILED
    java.lang.AssertionError: 
    Expected: not <DONE>
         but: was <DONE>
        at __randomizedtesting.SeedInfo.seed([F231651D93AD15B9:5F9AD649A6F577FB]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.junit.Assert.assertThat(Assert.java:930)
        at org.opensearch.indices.recovery.IndexRecoveryIT.assertOnGoingRecoveryState(IndexRecoveryIT.java:249)
        at org.opensearch.indices.recovery.IndexRecoveryIT.testRerouteRecovery(IndexRecoveryIT.java:697)

Created issue for the last failure #2502

Signed-off-by: Tianli Feng <ftianli@amazon.com>

opensearch-ci-bot · 2022-03-14T05:25:16Z

❌ Gradle Check failure 9c789ab78b03844087e9cf1cf8bc8463b9c5a51f
Log 3331

Reports 3331

opensearch-ci-bot · 2022-03-14T05:36:01Z

❌ Gradle Check failure ac29883
Log 3332

Reports 3332

tlfeng · 2022-03-14T05:38:48Z

In log 3332:

REPRODUCE WITH: ./gradlew ':qa:mixed-cluster:v1.2.5#mixedClusterTest' --tests "org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT" -Dtests.method="test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does}" -Dtests.seed=284B4865066BD7CB -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=et -Dtests.timezone=IST -Druntime.java=17

org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT > test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does} FAILED
    java.lang.AssertionError: Failure at [indices.get_field_mapping/20_missing_field:20]: field [test_index.mappings] is null
        at __randomizedtesting.SeedInfo.seed([284B4865066BD7CB:A01F77BFA897BA33]:0)
        at org.opensearch.test.rest.yaml.OpenSearchClientYamlSuiteTestCase.executeSection(OpenSearchClientYamlSuiteTestCase.java:442)
        at org.opensearch.test.rest.yaml.OpenSearchClientYamlSuiteTestCase.test(OpenSearchClientYamlSuiteTestCase.java:415)
...

It's reproduced in issue #2440

Signed-off-by: Tianli Feng <ftianli@amazon.com>

opensearch-ci-bot · 2022-03-14T23:49:23Z

✅ Gradle Check success 40a04e4
Log 3365

Reports 3365

dreamer-89

Nice! LGTM

kartg · 2022-03-16T19:06:52Z

server/src/main/java/org/opensearch/cluster/ClusterState.java

@@ -467,6 +473,11 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws
            builder.field("master_node", nodes().getMasterNodeId());
        }

+        // Value of the field is identical with the above, and aims to replace the above field.
+        if (metrics.contains(Metric.CLUSTER_MANAGER_NODE)) {
+            builder.field("cluster_manager_node", nodes().getMasterNodeId());


As noted on a related PR, please create a Github issue to track changing these internal methods to be inclusive

In my mind, it's not an internal method, because it's shown in the Javadoc (https://opensearch.org/javadocs/1.3.0/OpenSearch/server/build/docs/javadoc/org/opensearch/cluster/node/DiscoveryNodes.html#getMasterNodeId()).
I think method listed in Javadoc needs an enough period of time to deprecate in advance, before removing.
The issue to track the internal usages is #1548, and there is a PR out. Maybe I'd better update the description to list usages in different file directories.
(Pasted the related PR here #2453 (comment))

kartg · 2022-03-16T19:28:36Z

server/src/main/java/org/opensearch/rest/action/admin/cluster/RestClusterRerouteAction.java

+            // add the check of validating metrics set doesn't contain all enum elements.
+            if (!metrics.equals(EnumSet.allOf(ClusterState.Metric.class)) && metrics.contains(ClusterState.Metric.MASTER_NODE)) {
+                deprecationLogger.deprecate("cluster_reroute_metric_parameter_master_node_value", DEPRECATED_MESSAGE_MASTER_NODE);
+            }
        }
        return channel -> client.admin().cluster().reroute(clusterRerouteRequest, new RestToXContentListener<>(channel));


For my understanding - are there no changes needed here to support/parse the new cluster_manager_node parameter?

The new cluster_manager_node is a value of the request parameter metric. I think the only code to support is on above, where you posted a comment 😄.
Since it worked, I haven't revise the whole process of the parameter parsing.

Add cluster_manager_node into cluster state metric

c73c35c

Signed-off-by: Tianli Feng <ftianli@amazon.com>

tlfeng added enhancement Enhancement or improvement to existing feature or request v2.0.0 Version 2.0.0 documentation pending Tracks issues which have PRs merged but documentation changes pending labels Mar 9, 2022

tlfeng requested a review from a team as a code owner March 9, 2022 00:49

tlfeng mentioned this pull request Mar 9, 2022

Add alternative usages for the REST APIs and configurations that contain "master" terminology #1549

Closed

12 tasks

tlfeng added the >breaking Identifies a breaking change. label Mar 9, 2022

tlfeng marked this pull request as draft March 9, 2022 00:57

Add deprecation notice to MASTER_NODE enum value

e8dbdf2

Signed-off-by: Tianli Feng <ftianli@amazon.com>

tlfeng marked this pull request as ready for review March 9, 2022 01:05

Fix ClusterRerouteResponseTests

9bc6994

Signed-off-by: Tianli Feng <ftianli@amazon.com>

Modify deprecation javadoc

d2c177a

Signed-off-by: Tianli Feng <ftl94@live.com>

tlfeng force-pushed the replace-master-in-metric-parameter branch from 56b77a7 to d2c177a Compare March 9, 2022 19:15

Tianli Feng added 3 commits March 12, 2022 22:55

Merge branch 'main' into replace-master-in-metric-parameter

97f0f37

Signed-off-by: Tianli Feng <ftianli@amazon.com>

Add deprecation notice when using metric=master_node

d579487

Signed-off-by: Tianli Feng <ftianli@amazon.com>

Adjust format by spotlessApply task

0d66c0c

Signed-off-by: Tianli Feng <ftianli@amazon.com>

tlfeng marked this pull request as draft March 13, 2022 08:27

Tianli Feng added 2 commits March 13, 2022 21:54

Merge branch 'main' into replace-master-in-metric-parameter

7531fb7

Signed-off-by: Tianli Feng <ftianli@amazon.com>

Fix yaml rest test by adding allow warnings

ac29883

Signed-off-by: Tianli Feng <ftianli@amazon.com>

tlfeng force-pushed the replace-master-in-metric-parameter branch from 9c789ab to ac29883 Compare March 14, 2022 04:55

tlfeng marked this pull request as ready for review March 14, 2022 05:42

modify the condition to show deprecation notice

40a04e4

Signed-off-by: Tianli Feng <ftianli@amazon.com>

dblock requested a review from andrross March 15, 2022 15:45

tlfeng requested review from dreamer-89 and removed request for andrross March 16, 2022 02:34

dreamer-89 approved these changes Mar 16, 2022

View reviewed changes

kartg approved these changes Mar 16, 2022

View reviewed changes

tlfeng mentioned this pull request Mar 18, 2022

[CI] flaky test faiure - o.o.indices.recovery.IndexRecoveryIT.testRerouteRecovery #2502

Closed

tlfeng merged commit e0f7706 into opensearch-project:main Mar 18, 2022

tlfeng deleted the replace-master-in-metric-parameter branch March 18, 2022 22:09

tlfeng mentioned this pull request Apr 12, 2022

Added a new line linter #2875

Merged

5 tasks

tlfeng mentioned this pull request May 23, 2022

Replace internal usages of 'master' term in 'server/src/test' directory #2520

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 'cluster_manager_node' into ClusterState Metric as an alternative to 'master_node' #2415

Add 'cluster_manager_node' into ClusterState Metric as an alternative to 'master_node' #2415

tlfeng commented Mar 9, 2022 •

edited

Loading

opensearch-ci-bot commented Mar 9, 2022

opensearch-ci-bot commented Mar 9, 2022

opensearch-ci-bot commented Mar 9, 2022

opensearch-ci-bot commented Mar 9, 2022

tlfeng commented Mar 9, 2022 •

edited

Loading

tlfeng commented Mar 9, 2022

opensearch-ci-bot commented Mar 9, 2022

tlfeng commented Mar 9, 2022 •

edited

Loading

opensearch-ci-bot commented Mar 9, 2022

tlfeng commented Mar 9, 2022 •

edited

Loading

opensearch-ci-bot commented Mar 9, 2022

opensearch-ci-bot commented Mar 13, 2022

opensearch-ci-bot commented Mar 13, 2022

tlfeng commented Mar 14, 2022 •

edited

Loading

opensearch-ci-bot commented Mar 14, 2022

opensearch-ci-bot commented Mar 14, 2022

tlfeng commented Mar 14, 2022

opensearch-ci-bot commented Mar 14, 2022

dreamer-89 left a comment

kartg Mar 16, 2022

tlfeng Mar 17, 2022

kartg Mar 16, 2022

tlfeng Mar 17, 2022

Add 'cluster_manager_node' into ClusterState Metric as an alternative to 'master_node' #2415

Add 'cluster_manager_node' into ClusterState Metric as an alternative to 'master_node' #2415

Conversation

tlfeng commented Mar 9, 2022 • edited Loading

Description

Issues Resolved

Check List

opensearch-ci-bot commented Mar 9, 2022

opensearch-ci-bot commented Mar 9, 2022

opensearch-ci-bot commented Mar 9, 2022

opensearch-ci-bot commented Mar 9, 2022

tlfeng commented Mar 9, 2022 • edited Loading

tlfeng commented Mar 9, 2022

opensearch-ci-bot commented Mar 9, 2022

tlfeng commented Mar 9, 2022 • edited Loading

opensearch-ci-bot commented Mar 9, 2022

tlfeng commented Mar 9, 2022 • edited Loading

opensearch-ci-bot commented Mar 9, 2022

opensearch-ci-bot commented Mar 13, 2022

opensearch-ci-bot commented Mar 13, 2022

tlfeng commented Mar 14, 2022 • edited Loading

opensearch-ci-bot commented Mar 14, 2022

opensearch-ci-bot commented Mar 14, 2022

tlfeng commented Mar 14, 2022

opensearch-ci-bot commented Mar 14, 2022

dreamer-89 left a comment

Choose a reason for hiding this comment

kartg Mar 16, 2022

Choose a reason for hiding this comment

tlfeng Mar 17, 2022

Choose a reason for hiding this comment

kartg Mar 16, 2022

Choose a reason for hiding this comment

tlfeng Mar 17, 2022

Choose a reason for hiding this comment

tlfeng commented Mar 9, 2022 •

edited

Loading

tlfeng commented Mar 9, 2022 •

edited

Loading

tlfeng commented Mar 9, 2022 •

edited

Loading

tlfeng commented Mar 9, 2022 •

edited

Loading

tlfeng commented Mar 14, 2022 •

edited

Loading