Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate client transports to Apache HttpClient / Core 5.x #4459

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Migrate client transports to Apache HttpClient / Core 5.x #4459

merged 1 commit into from
Oct 11, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented Sep 8, 2022 •
edited
Loading

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Migrate client transports to Apache HttpClient / Core 5.x

Issues Resolved

Closes #4256

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL: null
  • CommitID: fe4996d

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL: null
  • CommitID: 340c027

@reta reta force-pushed the issue-4256 branch 2 times, most recently from f29fa47 to 4ca7793 Compare September 8, 2022 18:11
@reta reta changed the base branch from issue-4256 to main September 8, 2022 18:12
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta reta force-pushed the issue-4256 branch 2 times, most recently from f30a229 to 53994bb Compare September 27, 2022 18:25
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Gradle Check (Jenkins) Run Completed with:

@reta reta changed the title [WIP] Migrate client transports to Apache HttpClient / Core 5.x Migrate client transports to Apache HttpClient / Core 5.x Oct 5, 2022
@reta reta marked this pull request as ready for review October 5, 2022 20:27
@reta reta requested a review from a team as a code owner October 5, 2022 20:27
dblock
dblock approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admire your persistence @reta :) Did a cursory look and it looks all good to me. Are there any actual notable code changes that I may have missed or is it just a rename/moving things around?

@reta
Copy link
Collaborator Author

reta commented Oct 6, 2022 •
edited
Loading

Admire your persistence @reta :) Did a cursory look and it looks all good to me. Are there any actual notable code changes that I may have missed or is it just a rename/moving things around?

Thanks a mill @dblock ! There are two things I wanted to finish: a) to compare the CPU/memory usage between RestClient based on Apache HttpClient 4 vs 5.1, to make sure we have no leaks anywhere b) try to configure RestClient with HTTP/2.

Besides that, there is only one issue to mention which should be fixed in 5.1.4 release [1], other changes are pretty straightforward, thanks a lot for the review!

[1] https://github.com/opensearch-project/OpenSearch/pull/4459/files#diff-7c27327b9ea112ce87560831ddb6bd267e80837cd51c03796c8e2397f5b8a6a7R908

@dblock
Copy link
Member

dblock commented Oct 6, 2022

👍 feel free to merge at will

@reta
Migrate client transports to Apache HttpClient / Core 5.x
9e4daf6 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dblock
Copy link
Member

dblock commented Oct 11, 2022 •
edited
Loading

Merge? YOLO

@dblock dblock merged commit 4833e08 into opensearch-project:main Oct 11, 2022
@DarshitChanpura DarshitChanpura mentioned this pull request Oct 13, 2022
Closed
@saratvemulapalli
Copy link
Member

@dblock @reta looks like few plugins are failing.
Are we planing to get these changes to 2.x ?

@saratvemulapalli saratvemulapalli mentioned this pull request Oct 13, 2022
Merged
5 tasks
@joshpalis joshpalis mentioned this pull request Oct 13, 2022
Merged
5 tasks
@dblock
Copy link
Member

dblock commented Oct 14, 2022

@saratvemulapalli That would be breaking for 2.x, so no?

@reta
Copy link
Collaborator Author

reta commented Oct 17, 2022

@saratvemulapalli That would be breaking for 2.x, so no?

:+1 to @dblock's answer, sadly will be breaking change

@cwperks cwperks mentioned this pull request Oct 18, 2022
Merged
3 tasks
@saratvemulapalli saratvemulapalli mentioned this pull request Oct 18, 2022
Open
19 tasks
@saratvemulapalli
Copy link
Member

Thanks @reta @dblock. I've added this to #3351 .

@joshpalis joshpalis mentioned this pull request Nov 1, 2022
Closed
ashking94 pushed a commit to ashking94/OpenSearch that referenced this pull request Nov 7, 2022
@reta @ashking94
Migrate client transports to Apache HttpClient / Core 5.x (opensearch…
cb0c253 
…-project#4459)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@saratvemulapalli saratvemulapalli mentioned this pull request Dec 14, 2022
Closed
@joshpalis joshpalis mentioned this pull request Jan 20, 2023
Closed
@brokemyspoke brokemyspoke mentioned this pull request Jun 21, 2023
Open
@AhmadMS1988 AhmadMS1988 mentioned this pull request Sep 3, 2023
Closed
@kaituo kaituo mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate client transports to Apache HttpClient / Core 5.x
4 participants
@reta @codecov-commenter @dblock @saratvemulapalli