Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Javadoc] add missing javadocs for :distribution:tools modules #4483

Merged
merged 5 commits into from
Sep 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Support for labels on version bump PRs, skip label support for changelog verifier ([#4391](https://github.com/opensearch-project/OpenSearch/pull/4391))
- Update previous release bwc version to 2.4.0 ([#4455](https://github.com/opensearch-project/OpenSearch/pull/4455))
- 2.3.0 release notes ([#4457](https://github.com/opensearch-project/OpenSearch/pull/4457))
- Added missing javadocs for `:distribution:tools` modules ([#4483](https://github.com/opensearch-project/OpenSearch/pull/4483))

### Dependencies
- Bumps `org.gradle.test-retry` from 1.4.0 to 1.4.1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,10 @@
@Retention(RetentionPolicy.CLASS)
@Target({ ElementType.CONSTRUCTOR, ElementType.FIELD, ElementType.METHOD, ElementType.TYPE })
public @interface SuppressForbidden {
/**
* The argument to this annotation, specifying the reason a forbidden API is being used.
*
* @return The reason the error is being suppressed.
*/
String reason();
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
/*
* SPDX-License-Identifier: Apache-2.0
*
* The OpenSearch Contributors require contributions made to
* this file be licensed under the Apache-2.0 license or a
* compatible open source license.
*/

/**
* Tools to validate minimum version of the runtime Java.
*/
package org.opensearch.tools.java_version_checker;
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
import org.opensearch.cli.Terminal;

/**
* A cli tool for managing secrets in the opensearch keystore.
* A CLI tool for managing secrets in the OpenSearch keystore.
*/
public class KeyStoreCli extends LoggingAwareMultiCommand {

Expand All @@ -52,6 +52,12 @@ private KeyStoreCli() {
subcommands.put("has-passwd", new HasPasswordKeyStoreCommand());
}

/**
* Main entry point for the OpenSearch Keystore CLI tool.
*
* @param args CLI commands for managing secrets.
* @throws Exception if an exception was encountered executing the command.
*/
public static void main(String[] args) throws Exception {
exit(new KeyStoreCli().main(args, Terminal.DEFAULT));
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
/*
* SPDX-License-Identifier: Apache-2.0
*
* The OpenSearch Contributors require contributions made to
* this file be licensed under the Apache-2.0 license or a
* compatible open source license.
*/

/**
* Classes implementing a CLI tool for managing secrets in the OpenSearch keystore.
*/
package org.opensearch.common.settings;
1 change: 0 additions & 1 deletion distribution/tools/launchers/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,5 @@ testingConventions {
}

javadoc.enabled = false
missingJavadoc.enabled = false
loggerUsageCheck.enabled = false
jarHell.enabled = false
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
/*
* SPDX-License-Identifier: Apache-2.0
*
* The OpenSearch Contributors require contributions made to
* this file be licensed under the Apache-2.0 license or a
* compatible open source license.
*/

/**
* Classes implementing utility methods for launching JVMs.
*/
package org.opensearch.tools.launchers;
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
import java.util.Collections;

/**
* A cli tool for adding, removing and listing plugins for opensearch.
* A CLI tool for adding, removing and listing plugins for OpenSearch.
*/
public class PluginCli extends LoggingAwareMultiCommand {

Expand All @@ -56,6 +56,12 @@ private PluginCli() {
commands = Collections.unmodifiableCollection(subcommands.values());
}

/**
* Main entry point for the OpenSearch Plugin CLI tool.
*
* @param args CLI commands for managing plugins.
* @throws Exception if an exception was encountered executing the command.
*/
public static void main(String[] args) throws Exception {
exit(new PluginCli().main(args, Terminal.DEFAULT));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
*/
public class PluginHelper {

private PluginHelper() {}

/**
* Verify if a plugin exists with any folder name.
* @param pluginPath the path for the plugins directory.
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
/*
* SPDX-License-Identifier: Apache-2.0
*
* The OpenSearch Contributors require contributions made to
* this file be licensed under the Apache-2.0 license or a
* compatible open source license.
*/

/**
* Classes implementing a CLI tool for managing plugins in OpenSearch.
*/
package org.opensearch.plugins;
4 changes: 0 additions & 4 deletions gradle/missing-javadoc.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,6 @@ configure([
project(":client:client-benchmark-noop-api-plugin"),
project(":client:rest-high-level"),
project(":client:test"),
project(":distribution:tools:java-version-checker"),
project(":distribution:tools:keystore-cli"),
project(":distribution:tools:launchers"),
project(":distribution:tools:plugin-cli"),
project(":doc-tools"),
project(":example-plugins:custom-settings"),
project(":example-plugins:custom-significance-heuristic"),
Expand Down