-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add groupId value propagation tests for ZIP publication task #4772
Conversation
a356d8d
to
9bc7589
Compare
Gradle Check (Jenkins) Run Completed with:
|
9bc7589
to
505a1fa
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Hmm... Flaky tests again? (Timing out...) |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #4772 +/- ##
============================================
+ Coverage 70.66% 70.72% +0.06%
- Complexity 57578 57636 +58
============================================
Files 4661 4669 +8
Lines 276662 276863 +201
Branches 40325 40346 +21
============================================
+ Hits 195501 195821 +320
+ Misses 64926 64713 -213
- Partials 16235 16329 +94
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
505a1fa
to
be0cb20
Compare
Gradle Check (Jenkins) Run Completed with:
|
buildSrc/src/test/java/org/opensearch/gradle/pluginzip/PublishTests.java
Show resolved
Hide resolved
The groupId can be defined on several levels. This commit adds more tests to cover the "edge" cases. - In one case the groupId is inherited from the top most 'allprojects' section (and thus can be missing in the publications section). - The other case is opposite, it tests that if the groupId is defined on several levels then the most internal level outweighs the other levels. Closes: opensearch-project#4771 Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
be0cb20
to
5f6e041
Compare
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-4772-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 eb3301554ec7e1a07866508ffc390b8651dc3394
# Push it to GitHub
git push --set-upstream origin backport/backport-4772-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
This is back-port of opensearch-project#4772 Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io> (cherry picked from commit eb33015)
I fixed the back-port PR manually (Resolved conflicts) and prepared a new PR here #4848 I do not think I can do
so I did
|
This is back-port of opensearch-project#4772 Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io> (cherry picked from commit eb33015)
This is back-port of opensearch-project#4772 Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io> (cherry picked from commit eb33015)
…rch-project#4772) The groupId can be defined on several levels. This commit adds more tests to cover the "edge" cases. - In one case the groupId is inherited from the top most 'allprojects' section (and thus can be missing in the publications section). - The other case is opposite, it tests that if the groupId is defined on several levels then the most internal level outweighs the other levels. Closes: opensearch-project#4771 Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io> Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
Description
The groupId can be defined on several levels. This commit adds more tests to cover the "edge" cases.
allprojects
section (and thus can be missing in the publications section).Issues Resolved
Closes: #4771
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Lukáš Vlček lukas.vlcek@aiven.io