Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable merge on refresh in DiskThresholdDeciderIT #4828

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Oct 18, 2022

Disables merge on refresh for DiskThresholdDeciderIT.testRestoreSnapshotAllocationDoesNotExceedWatermark. This fixes reproducible failure on main and 2.x branches:

./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testRestoreSnapshotAllocationDoesNotExceedWatermark" -Dtests.seed=926BB9577ACEFB6 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-PR -Dtests.timezone=America/Virgin -Druntime.java=17

closes #4162

Disables merge on refresh for
DiskThresholdDeciderIT.testRestoreSnapshotAllocationDoesNotExceedWatermark.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize added bug Something isn't working :test Adding or fixing a test v3.0.0 Issues and PRs related to version 3.0.0 backport 2.x Backport to 2.x branch labels Oct 18, 2022
@nknize nknize requested review from a team and reta as code owners October 18, 2022 19:12
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@reta
Copy link
Collaborator

reta commented Oct 18, 2022

Issue #4162

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize
Copy link
Collaborator Author

nknize commented Oct 18, 2022

#4830

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #4828 (493a629) into main (cdc7a2f) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##               main    #4828      +/-   ##
============================================
- Coverage     70.74%   70.73%   -0.02%     
+ Complexity    57888    57868      -20     
============================================
  Files          4689     4689              
  Lines        277305   277296       -9     
  Branches      40370    40363       -7     
============================================
- Hits         196190   196138      -52     
- Misses        64794    64893      +99     
+ Partials      16321    16265      -56     
Impacted Files Coverage Δ
...reness/get/GetDecommissionStateRequestBuilder.java 0.00% <0.00%> (ø)
...eness/get/TransportGetDecommissionStateAction.java 23.07% <0.00%> (-1.93%) ⬇️
.../org/opensearch/client/support/AbstractClient.java 32.54% <ø> (ø)
.../admin/cluster/RestGetDecommissionStateAction.java 42.85% <25.00%> (-17.15%) ⬇️
...on/awareness/get/GetDecommissionStateResponse.java 42.85% <47.36%> (-1.92%) ⬇️
...ion/awareness/get/GetDecommissionStateRequest.java 82.35% <83.33%> (+82.35%) ⬆️
...adonly/AddIndexBlockClusterStateUpdateRequest.java 0.00% <0.00%> (-75.00%) ⬇️
...luster/routing/allocation/RoutingExplanations.java 41.37% <0.00%> (-58.63%) ⬇️
...readonly/TransportVerifyShardIndexBlockAction.java 9.75% <0.00%> (-58.54%) ⬇️
.../admin/cluster/reroute/ClusterRerouteResponse.java 55.00% <0.00%> (-45.00%) ⬇️
... and 478 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nknize nknize merged commit 49363fb into opensearch-project:main Oct 19, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-4828-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 49363fb06a4cbd48e6baa90f53b74764fb8ec155
# Push it to GitHub
git push --set-upstream origin backport/backport-4828-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4828-to-2.x.

nknize added a commit to nknize/OpenSearch that referenced this pull request Oct 19, 2022
…t#4828)

Disables merge on refresh for DiskThresholdDeciderIT.testRestoreSnapshotAllocationDoesNotExceedWatermark.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 49363fb)
reta pushed a commit that referenced this pull request Oct 19, 2022
Disables merge on refresh for DiskThresholdDeciderIT.testRestoreSnapshotAllocationDoesNotExceedWatermark.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 49363fb)
ashking94 pushed a commit to ashking94/OpenSearch that referenced this pull request Nov 7, 2022
…t#4828)

Disables merge on refresh for DiskThresholdDeciderIT.testRestoreSnapshotAllocationDoesNotExceedWatermark.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working :test Adding or fixing a test v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
3 participants