Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing blacklist by blocklist and whitelist by allowlist #729

Closed
wants to merge 5 commits into from
Closed

Conversation

aponb
Copy link
Contributor

@aponb aponb commented May 19, 2021

Description

opensearch should be open enough to avoid the words "blacklist" and "whitelist"

Issues Resolved

Check List

  • All tests pass

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

❌   DCO Check Failed e3ddf3c
Run ./dev-tools/signoff-check.sh remotes/origin/main e3ddf3c59b6e1d4c4c0e9012f83e542148a96eee to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success e3ddf3c

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure e3ddf3c
Log 434

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success a4e669f

@opensearch-ci-bot
Copy link
Collaborator

❌   DCO Check Failed a4e669f
Run ./dev-tools/signoff-check.sh remotes/origin/main a4e669f236379c96ee55d8f914f5b1b09232ab02 to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure a4e669f
Log 441

@opensearch-ci-bot
Copy link
Collaborator

❌   DCO Check Failed 5de25dd
Run ./dev-tools/signoff-check.sh remotes/origin/main 5de25dd407c92edbdd64f92c6b3d6f09d3f6ccd1 to check locally
Use git commit with -s to add 'Signed-of-by: {EMAIL}' on impacted commits

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 5de25dd

@aponb aponb closed this May 20, 2021
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure 5de25dd
Log 443

@dblock
Copy link
Member

dblock commented May 20, 2021

We'd like to do this, however we also need to preserve backwards compatibility, see #472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants