Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Changes in Snapshot Delete Flow for remote store interoperability. #7497

Merged
merged 7 commits into from
Jul 11, 2023

Conversation

kasundra07
Copy link
Contributor

@kasundra07 kasundra07 commented May 10, 2023

Description

Changes in Delete Snapshot API required for Snapshot interoperability with Remote Store.

Related Issues

This change is dependent on Lock Manager changes and Create Snapshot API changes.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kasundra07 kasundra07 force-pushed the deleteSnapshot branch 2 times, most recently from 48a79f3 to 18d5315 Compare May 17, 2023 21:11
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Collaborator

@sohami sohami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreIT.testStaleCommitDeletionWithInvokeFlush

@gbbafna
Copy link
Collaborator

gbbafna commented Jul 11, 2023

Please create a backlog item for ITs where deletion of lock files and .dat files fail . Rest LGTM .

@gbbafna gbbafna merged commit a430e18 into opensearch-project:main Jul 11, 2023
8 of 9 checks passed
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Jul 11, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7497-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a430e18e82f7671e01c37ae5a549fc36dd673b1a
# Push it to GitHub
git push --set-upstream origin backport/backport-7497-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7497-to-2.x.

harishbhakuni pushed a commit to harishbhakuni/OpenSearch that referenced this pull request Jul 11, 2023
opensearch-project#7497)

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
(cherry picked from commit a430e18)
kasundra07 added a commit to harishbhakuni/OpenSearch that referenced this pull request Jul 11, 2023
opensearch-project#7497)

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
(cherry picked from commit a430e18)
sachinpkale pushed a commit to sachinpkale/OpenSearch that referenced this pull request Jul 11, 2023
sachinpkale pushed a commit to sachinpkale/OpenSearch that referenced this pull request Jul 11, 2023
dbwiddis pushed a commit that referenced this pull request Jul 11, 2023
…nteroperability. (#7497) (#8627)

* Add Changes in Snapshot Delete Flow for remote store interoperability. (#7497)

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>

* Spotless fixes

Signed-off-by: Sachin Kale <kalsac@amazon.com>

---------

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Bansi Kasundra <66969140+kasundra07@users.noreply.github.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
vikasvb90 pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
raghuvanshraj pushed a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 12, 2023
dzane17 pushed a commit to dzane17/OpenSearch that referenced this pull request Jul 12, 2023
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
opensearch-project#7497)

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
opensearch-project#7497)

Signed-off-by: Bansi Kasundra <kasundra@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants