[Refactor] StreamIO from common to core.common namespace in core lib #8157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nknize
added
enhancement
nknize
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis and
sachinpkale
as code owners
Gradle Check (Jenkins) Run Completed with:
|
nknize
changed the title
9 tasks
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
navneet1v
added a commit
to navneet1v/k-NN
that referenced
this pull request
Jul 13, 2023
…n OpenSeach core via PR: opensearch-project/OpenSearch#8157 Signed-off-by: Navneet Verma <navneev@amazon.com>
5 tasks
navneet1v
added a commit
to navneet1v/k-NN
that referenced
this pull request
Jul 13, 2023
…n OpenSearch core via PR: opensearch-project/OpenSearch#8157 Signed-off-by: Navneet Verma <navneev@amazon.com>
This was referenced Jul 13, 2023
navneet1v
added a commit
to opensearch-project/k-NN
that referenced
this pull request
Jul 13, 2023
…n OpenSearch core via PR: opensearch-project/OpenSearch#8157 (#981)
1 task
Merged
2 tasks
2 tasks
This was referenced Jul 13, 2023
1 task
1 task
buddharajusahil
pushed a commit
to buddharajusahil/OpenSearch
that referenced
this pull request
Jul 18, 2023
…pensearch-project#8157) * [Refactor] StreamIO from common to core.common in core lib This PR is a mechanical refactor of all Stream classes in o.o.common.io.stream to o.o.core.common.io.stream namespace. In addition to the namespace refactor several loose end classes in o.o.common.io.stream of the :server module are refactored to o.o.core.common.io.stream of the :libs:opensearch-core library. These classes include the following: * ByteBufferStreamInpu * BytesStreamInput * DataOutputStreamOutput * FilterStreamInput * NamedWriteableAwareStreamInput * OutputStreamStreamOutput * VersionedNamedWriteable Companion tests are also refactored from the server test folder to the corresponding core test folder. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize
added a commit
to nknize/OpenSearch
that referenced
this pull request
Jul 19, 2023
…pensearch-project#8157) * [Refactor] StreamIO from common to core.common in core lib This PR is a mechanical refactor of all Stream classes in o.o.common.io.stream to o.o.core.common.io.stream namespace. In addition to the namespace refactor several loose end classes in o.o.common.io.stream of the :server module are refactored to o.o.core.common.io.stream of the :libs:opensearch-core library. These classes include the following: * ByteBufferStreamInpu * BytesStreamInput * DataOutputStreamOutput * FilterStreamInput * NamedWriteableAwareStreamInput * OutputStreamStreamOutput * VersionedNamedWriteable Companion tests are also refactored from the server test folder to the corresponding core test folder. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
andrross
pushed a commit
that referenced
this pull request
Jul 19, 2023
…ce in core lib (#8157) (#8782) * [Refactor] StreamIO from common to core.common namespace in core lib (#8157) * [Refactor] StreamIO from common to core.common in core lib This PR is a mechanical refactor of all Stream classes in o.o.common.io.stream to o.o.core.common.io.stream namespace. In addition to the namespace refactor several loose end classes in o.o.common.io.stream of the :server module are refactored to o.o.core.common.io.stream of the :libs:opensearch-core library. These classes include the following: * ByteBufferStreamInpu * BytesStreamInput * DataOutputStreamOutput * FilterStreamInput * NamedWriteableAwareStreamInput * OutputStreamStreamOutput * VersionedNamedWriteable Companion tests are also refactored from the server test folder to the corresponding core test folder. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> * update changelog Signed-off-by: Nicholas Walter Knize <nknize@apache.org> --------- Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
This was referenced Jul 21, 2023
monusingh-1
added a commit
to opensearch-project/cross-cluster-replication
that referenced
this pull request
Jul 21, 2023
Keep up with core changes opensearch-project/OpenSearch#8157 move from common to core.common Change kotlin.version "1.8.21" as Class 'org.opensearch.commons.utils.OpenForTesting' was compiled with "1.8.21" version of Kotlin. Ref Set following to use 1.6 as 1.8.21 is not available yet. Checked that other OpenSearch plugins are also doing the same. Set kotlinx-coroutines-core to 1.6.0 set kotlinx-coroutines-test to 1.6.0 Added else in when statements as from Kotlin 1.7 version onward exhaustive list is mandatory. 'when' expression must be exhaustive, add necessary 'else' branch --------- Signed-off-by: monusingh-1 <msnghgw@amazon.com>
monusingh-1
added a commit
to monusingh-1/ccr-dev
that referenced
this pull request
Jul 24, 2023
Keep up with core changes opensearch-project/OpenSearch#8157 move from common to core.common Change kotlin.version "1.8.21" as Class 'org.opensearch.commons.utils.OpenForTesting' was compiled with "1.8.21" version of Kotlin. Ref Set following to use 1.6 as 1.8.21 is not available yet. Checked that other OpenSearch plugins are also doing the same. Set kotlinx-coroutines-core to 1.6.0 set kotlinx-coroutines-test to 1.6.0 Added else in when statements as from Kotlin 1.7 version onward exhaustive list is mandatory. 'when' expression must be exhaustive, add necessary 'else' branch --------- Signed-off-by: monusingh-1 <msnghgw@amazon.com>
monusingh-1
added a commit
to opensearch-project/cross-cluster-replication
that referenced
this pull request
Jul 25, 2023
* Open Upgrade gradle version and remove remaining use of ImmutableOpenMap (#814) Signed-off-by: Monu Singh <msnghgw@amazon.com> * Move from common to core.common (#1087) Keep up with core changes opensearch-project/OpenSearch#8157 move from common to core.common Change kotlin.version "1.8.21" as Class 'org.opensearch.commons.utils.OpenForTesting' was compiled with "1.8.21" version of Kotlin. Ref Set following to use 1.6 as 1.8.21 is not available yet. Checked that other OpenSearch plugins are also doing the same. Set kotlinx-coroutines-core to 1.6.0 set kotlinx-coroutines-test to 1.6.0 Added else in when statements as from Kotlin 1.7 version onward exhaustive list is mandatory. 'when' expression must be exhaustive, add necessary 'else' branch --------- Signed-off-by: monusingh-1 <msnghgw@amazon.com> --------- Signed-off-by: Monu Singh <msnghgw@amazon.com> Signed-off-by: monusingh-1 <msnghgw@amazon.com>
baba-devv
pushed a commit
to baba-devv/OpenSearch
that referenced
this pull request
Jul 29, 2023
…pensearch-project#8157) * [Refactor] StreamIO from common to core.common in core lib This PR is a mechanical refactor of all Stream classes in o.o.common.io.stream to o.o.core.common.io.stream namespace. In addition to the namespace refactor several loose end classes in o.o.common.io.stream of the :server module are refactored to o.o.core.common.io.stream of the :libs:opensearch-core library. These classes include the following: * ByteBufferStreamInpu * BytesStreamInput * DataOutputStreamOutput * FilterStreamInput * NamedWriteableAwareStreamInput * OutputStreamStreamOutput * VersionedNamedWriteable Companion tests are also refactored from the server test folder to the corresponding core test folder. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…pensearch-project#8157) * [Refactor] StreamIO from common to core.common in core lib This PR is a mechanical refactor of all Stream classes in o.o.common.io.stream to o.o.core.common.io.stream namespace. In addition to the namespace refactor several loose end classes in o.o.common.io.stream of the :server module are refactored to o.o.core.common.io.stream of the :libs:opensearch-core library. These classes include the following: * ByteBufferStreamInpu * BytesStreamInput * DataOutputStreamOutput * FilterStreamInput * NamedWriteableAwareStreamInput * OutputStreamStreamOutput * VersionedNamedWriteable Companion tests are also refactored from the server test folder to the corresponding core test folder. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a mechanical refactor of all Stream classes in o.o.common.io.stream to o.o.core.common.io.stream namespace. In addition to the namespace refactor several loose end classes in o.o.common.io.stream of the :server module are refactored to o.o.core.common.io.stream of the :libs:opensearch-core library. These classes include the following:
Companion tests are also refactored from the server test folder to the corresponding core test folder.
relates #5910
relates #8110
supersedes #7783