Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure IndexOutput of metadata file is always closed (#8653) #8656

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Make sure IndexOutput of metadata file is always closed (#8653) #8656

merged 1 commit into from
Jul 12, 2023

Conversation

sachinpkale
Copy link
Member

@sachinpkale sachinpkale commented Jul 12, 2023 •
edited
Loading

Backports #8653 to 2.9

Resolves #8638

@sachinpkale
Make sure IndexOutput of metadata file is always closed (opensearch-p…
27c539d 
…roject#8653)

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPitCreatedOnReplica

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #8656 (27c539d) into 2.9 (54eef1f) will decrease coverage by 0.43%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.9    #8656      +/-   ##
============================================
- Coverage     71.05%   70.63%   -0.43%     
+ Complexity    57461    57124     -337     
============================================
  Files          4745     4745              
  Lines        270757   270756       -1     
  Branches      39961    39961              
============================================
- Hits         192390   191243    -1147     
- Misses        62154    63062     +908     
- Partials      16213    16451     +238
Impacted Files Coverage Δ
...earch/index/store/RemoteSegmentStoreDirectory.java 92.05% <100.00%> (+2.75%) ⬆️

... and 459 files with indirect coverage changes

@sachinpkale sachinpkale merged commit 9087d05 into opensearch-project:2.9 Jul 12, 2023
11 of 33 checks passed
@dreamer-89 dreamer-89 mentioned this pull request Jul 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbafna gbbafna gbbafna approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89 dreamer-89 is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng tlfeng is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sachinpkale @gbbafna