-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix testUploadMetadataMissingSegment unit test on 2.x #9099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suraj Singh <surajrider@gmail.com>
dreamer-89
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
tlfeng,
VachaShah,
dbwiddis,
sachinpkale and
sohami
as code owners
August 3, 2023 19:26
dreamer-89
changed the title
Fix unit test on 2.x
Fix testUploadMetadataMissingSegment unit test on 2.x
Aug 3, 2023
mch2
approved these changes
Aug 3, 2023
Compatibility status:
|
6 tasks
kotwanikunal
approved these changes
Aug 3, 2023
Poojita-Raj
approved these changes
Aug 3, 2023
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #9099 +/- ##
============================================
+ Coverage 70.72% 70.84% +0.12%
- Complexity 57372 57473 +101
============================================
Files 4754 4754
Lines 271625 271650 +25
Branches 40066 40067 +1
============================================
+ Hits 192102 192460 +358
+ Misses 62972 62705 -267
+ Partials 16551 16485 -66
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes unit test
testUploadMetadataMissingSegment
by fetching primary term from ReplicationCheckpoint vs using hard-coded value.Related Issues
Resolves #9096
Test
Ran this test 1k times successfully without failure
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.