Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging for version increment automation #161

Merged
merged 4 commits into from
Aug 11, 2022

Conversation

prudhvigodithi
Copy link
Contributor

Description

This is the staging PR for to execute workflows that auto raise the version increment PR's
Example: prudhvigodithi#1

Issues Resolved

Part of: opensearch-project/opensearch-build#1375
From solution: opensearch-project/opensearch-build#1375 (comment)
Related issue: #154

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
@prudhvigodithi
Copy link
Contributor Author

Referenced old 1.x version increment PR #155.

@prudhvigodithi
Copy link
Contributor Author

Hey @Bukhtawar @eirsep can you please take a look.
Thank you
@bbarani

@bharath-techie
Copy link
Collaborator

@prudhvigodithi can you fix build failures, or is this related to gradle check failures which needs a fix.

@prudhvigodithi
Copy link
Contributor Author

@prudhvigodithi can you fix build failures, or is this related to gradle check failures which needs a fix.

Hey @bharath-techie I assume these failure are not caused with this change, can you also please confirm?
Thank you

@prudhvigodithi
Copy link
Contributor Author

Hey @bharath-techie can you please take a look at those failures and confirm the cause, I'm sure its not because of this change :)
Thank you

@bharath-techie
Copy link
Collaborator

Execution failed for task ':compileTestJava'.
> Could not resolve all dependencies for configuration ':testCompileClasspath'.
   > Conflict(s) found for the following module(s):
       - junit:junit between versions 4.13.2 and 4.12
     Run with:
         --scan or
         :dependencyInsight --configuration testCompileClasspath --dependency junit:junit
     to get more insight on how to solve the conflict.

This is the error we are getting.

@prudhvigodithi
Copy link
Contributor Author

Hey @bharath-techie I'm sure this is not with this PR, was this always failing for 1.x?
Thank you
@bbarani

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
@prudhvigodithi
Copy link
Contributor Author

Hey @bharath-techie I have updated the PR with change in Junit version.
Thank you

@dhruv16dhr dhruv16dhr self-requested a review August 10, 2022 12:08
@bharath-techie bharath-techie merged commit a903b56 into opensearch-project:1.x Aug 11, 2022
@prudhvigodithi
Copy link
Contributor Author

Hey @dhruv16dhr @bharath-techie I dont see this is backported to 1.3 branch, can you please take a look?
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants