Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ui metadata in workflow object #458

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Jun 21, 2023

add ui metadata in worklfow object similar to ui metadata object present in monitor. this is required for dashboards to store metadata information

Signed-off-by: Surya Sashank Nistala <snistala@amazon.com>
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #458 (4abfb76) into main (5ef9b55) will decrease coverage by 0.03%.
The diff coverage is 90.00%.

@@             Coverage Diff              @@
##               main     #458      +/-   ##
============================================
- Coverage     73.78%   73.76%   -0.03%     
- Complexity      819      820       +1     
============================================
  Files           126      126              
  Lines          5341     5348       +7     
  Branches        675      676       +1     
============================================
+ Hits           3941     3945       +4     
- Misses         1103     1104       +1     
- Partials        297      299       +2     
Impacted Files Coverage Δ
.../org/opensearch/commons/alerting/model/Workflow.kt 80.86% <90.00%> (-1.08%) ⬇️

@lezzago lezzago changed the title add ui metadata in worklfow object add ui metadata in workflow object Jun 21, 2023
@lezzago
Copy link
Member

lezzago commented Jun 21, 2023

There has been talks about going away from this logic since if someone creates the monitor/workflow through the api, it can never be converted to the visual mode even if the visual mode would support that configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants