[Backport 2.x] Adding EntityType to Comment Model (#671) #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding entityType to Comment model Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * updated tests Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * removing EntityType enum class, entity type in documents will just be strings Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * fixed unit tests Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * adding tests and release notes Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * moved comment test to WriteableTests Signed-off-by: Dennis Toepker <toepkerd@amazon.com> * updated writeable test Signed-off-by: Dennis Toepker <toepkerd@amazon.com> --------- Signed-off-by: Dennis Toepker <toepkerd@amazon.com> Co-authored-by: Dennis Toepker <toepkerd@amazon.com>
jowg-amazon
approved these changes
Jun 12, 2024
AWSHurneyt
approved these changes
Jun 12, 2024
5 tasks
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
* adding entityType to Comment model * updated tests * removing EntityType enum class, entity type in documents will just be strings * fixed unit tests * adding tests and release notes * moved comment test to WriteableTests * updated writeable test --------- Signed-off-by: Dennis Toepker <toepkerd@amazon.com> Co-authored-by: Dennis Toepker <toepkerd@amazon.com> (cherry picked from commit 841fd4d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Jun 12, 2024
* adding entityType to Comment model * updated tests * removing EntityType enum class, entity type in documents will just be strings * fixed unit tests * adding tests and release notes * moved comment test to WriteableTests * updated writeable test --------- (cherry picked from commit 841fd4d) Signed-off-by: Dennis Toepker <toepkerd@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Dennis Toepker <toepkerd@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding entityType to Comment model
updated tests
removing EntityType enum class, entity type in documents will just be strings
fixed unit tests
adding tests and release notes
moved comment test to WriteableTests
updated writeable test
Description
Manual backport to 2.x of PR #671
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.