Skip to content

Commit

Permalink
Javadoc fixes (#3594)
Browse files Browse the repository at this point in the history
Signed-off-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
Co-authored-by: Krishna Kondaka <krishkdk@dev-dsk-krishkdk-2c-bd29c437.us-west-2.amazon.com>
  • Loading branch information
kkondaka and Krishna Kondaka committed Nov 7, 2023
1 parent a40f4b8 commit 15d8247
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ public <T> List<T> getTypedList(final String attribute, final Class<T> type) {
* Returns the value of the specified {@literal List<Map<String, String>>}, or {@code defaultValue} if this settings contains no value for
* the attribute.
*
* @param attribute attribute to be looked up
* @param keyType key type of the Map
* @param valueType value type stored in the Map
* @param <K> The key type
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ public interface EventHandle {
*/
Instant getInternalOriginationTime();

/**
* registers onRelease consumer with event handle
*
* @param releaseConsumer consumer to be calledback when event handle is released.
*/
void onRelease(BiConsumer<EventHandle, Boolean> releaseConsumer);

}
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ public interface PluginConfigObservable {

/**
* Onboard a new {@link PluginConfigObserver} within the plugin.
*
* @param pluginConfigObserver plugin config observer
* @return returns true if the opration is successful, false otherwise
*/
boolean addPluginConfigObserver(PluginConfigObserver pluginConfigObserver);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
public interface PluginConfigPublisher {
/**
* Onboard a new {@link PluginConfigObservable}.
*
* @param pluginConfigObservable observable plugin configuration
* @return true if the operation is successful, false otherwise
*/
boolean addPluginConfigObservable(PluginConfigObservable pluginConfigObservable);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ public interface PluginFactory {
*
* @param baseClass The class type that the plugin is supporting.
* @param pluginSetting The {@link PluginSetting} to configure this plugin
* @param args variable number of arguments
* @param <T> The type
* @return A new instance of your plugin, configured
* @since 1.2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@ public void setSourcePartitionStoreItem(SourcePartitionStoreItem sourcePartition
/**
* Helper method to convert progress state.
* This is because the state is currently stored as a String in the coordination store.
*
* @param progressStateClass class of progress state
* @param serializedPartitionProgressState serialized value of the partition progress state
*
* @return returns the converted value of the progress state
*/
public T convertStringToPartitionProgressState(Class<T> progressStateClass, final String serializedPartitionProgressState) {
if (Objects.isNull(serializedPartitionProgressState)) {
Expand All @@ -69,6 +74,9 @@ public T convertStringToPartitionProgressState(Class<T> progressStateClass, fina
/**
* Helper method to convert progress state to String
* This is because the state is currently stored as a String in the coordination store.
*
* @param partitionProgressState optional parameter indicating the partition progress state
* @return returns the progress state as string
*/
public String convertPartitionProgressStatetoString(Optional<T> partitionProgressState) {
if (partitionProgressState.isEmpty()) {
Expand Down

0 comments on commit 15d8247

Please sign in to comment.