Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.5] Add inline template_content support to the opensearch sink (#3431) #3453

Merged

Conversation

graytaylor0
Copy link
Member

Signed-off-by: Taylor Gray tylgry@amazon.com
(cherry picked from commit e19ae8f)

Description

Manual Backport for #3431

Issues Resolved

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@graytaylor0 graytaylor0 changed the title Add inline template_content support to the opensearch sink (#3431) [Backport 2.5] Add inline template_content support to the opensearch sink (#3431) Oct 6, 2023
@graytaylor0 graytaylor0 closed this Oct 6, 2023
@graytaylor0 graytaylor0 reopened this Oct 6, 2023
…h-project#3431)

Signed-off-by: Taylor Gray <tylgry@amazon.com>
(cherry picked from commit e19ae8f)
dlvenable
dlvenable previously approved these changes Oct 6, 2023
Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You have a merge conflict.

I wonder if you can re-generate a backport. Maybe delete this, then re-add the backport 2.5 tag on the source PR?

Signed-off-by: Taylor Gray <tylgry@amazon.com>
@graytaylor0 graytaylor0 merged commit c9a63c9 into opensearch-project:2.5 Oct 6, 2023
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants