Adds Kafka producer metrics for buffer usage #4139
Conversation
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed and
oeyh
as code owners
Signed-off-by: David Venable <dlv@amazon.com>
dlvenable
force-pushed
the
kafka-producer-metrics
branch
from
f24d5b0
to
408ac60
Compare
|
|
||
| final Metric metric = metricNameEntry.getValue(); | ||
|
|
||
| pluginMetrics.gauge(dataPrepperMetricName, metric, m -> (double) m.metricValue()); |
There was a problem hiding this comment.
Will this metrics be emitted only once when the producer is initialized ?
There was a problem hiding this comment.
That should be correct. The producer already exists as it is passed in here, so it does exist.
There was a problem hiding this comment.
Should this metrics be continuously emitted at regular interval ? For example the topic metrics are emitted when record is produced.
There was a problem hiding this comment.
@dinujoh , I may have misunderstood you at first. Now I see that you are asking if this metric is only emitted once.
Micrometer controls the timing for gauges. So Micrometer will make this call every minute (this is the current configuration) and get the actual value at that point in time. So the metric is updated regularly.
There was a problem hiding this comment.
To clarify, Micrometer calls the DoubleFunction every minute. Thus, it calls m -> (double) m.metricValue() every minute.
Description
This PR adds three new metrics for the
kafkabuffer:These are not topic-related, so I connected it to the
KafkaProduceritself.Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.