Caching implementation of EventKeyFactory #4843
Conversation
…configurable number of EventKeys. Signed-off-by: David Venable <dlv@amazon.com>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter and
oeyh
as code owners
|
See #4842 for how this can help with performance for |
| @Inject | ||
| CachingEventKeyFactory(final EventKeyFactory delegateEventKeyFactory, final EventConfiguration eventConfiguration) { | ||
| this.delegateEventKeyFactory = delegateEventKeyFactory; | ||
| cache = Caffeine.newBuilder() |
There was a problem hiding this comment.
Nice! I was not familiar with this library before
There was a problem hiding this comment.
Caffeine is preferred over the Guava cache. And we actually have a Checkstyle to prevent use of the Guava cache.
|
I see the build is failing |
…lways remove items when we need. Signed-off-by: David Venable <dlv@amazon.com>
…tion context for a couple of reasons: 1. Allow for skipping the CachingEventKeyFactory if not needed; 2. Help it run better in the data-prepper-test-event project. Signed-off-by: David Venable <dlv@amazon.com>
Signed-off-by: David Venable <dlv@amazon.com>
Signed-off-by: David Venable <dlv@amazon.com>
| final String key = UUID.randomUUID().toString(); | ||
| final EventKey eventKey = mock(EventKey.class); | ||
|
|
||
| when(innerEventKeyFactory.createEventKey(key, EventKeyFactory.EventAction.ALL)).thenReturn(eventKey); |
There was a problem hiding this comment.
What is this test testing? Since we are returning via when it will be same instance, right? Isn't it better to use the real createEventKey()?
There was a problem hiding this comment.
Overall, this test is verifying the behavior of createEventKey(String) in the CachingEventKeyFactory. The interface has a default implementation for createEventKey(final String key):
The CachingEventKeyFactory actually uses this default implementation, which then calls the custom implementation for caching.
The real implementations are being used in this test. Please note that I am not using a spy on the object under test. On this line, I have mocked the inner object. This is the same as on line 55 above. The difference is that because of the default implementation, the call comes in providing EventAction.ALL.
Description
Update the
EventKeyFactoryto support caching ofEventKeyobjects across plugins and within them.Also adds a configuration to data-prepper-config.yaml:
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.