Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README.md according to previous changes of docker files. #4845

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

jayeshjeh
Copy link
Contributor

@jayeshjeh jayeshjeh commented Aug 18, 2024

Description

README.md has been updated according to the new changes pushed into the /examples/log-ingestion/ in last commit.
One can follow and understand better.

Issues Resolved

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: jayeshjeh <jay.parmar.11169@gmail.com>
Signed-off-by: jayeshjeh <jay.parmar.11169@gmail.com>
Copy link
Collaborator

@KarstenSchnitter KarstenSchnitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing this change. I found just one minor typo. I did not try out the procedure to compare with the documentation though.

examples/log-ingestion/README.md Outdated Show resolved Hide resolved
jayeshjeh and others added 2 commits August 23, 2024 19:00
Signed-off-by: jayeshjeh <jay.parmar.11169@gmail.com>
Copy link
Collaborator

@KarstenSchnitter KarstenSchnitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

@jayeshjeh
Copy link
Contributor Author

If any other changes required, please let me know.

@KarstenSchnitter KarstenSchnitter merged commit 0d121bc into opensearch-project:main Sep 9, 2024
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants