Fix a bug with event listener in RDS source #4962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hai Yan <oeyh@amazon.com>
oeyh
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter and
dlvenable
as code owners
san81
approved these changes
Sep 19, 2024
dlvenable
requested changes
Sep 19, 2024
| @@ -146,6 +146,7 @@ public void onEvent(com.github.shyiko.mysql.binlog.event.Event event) { | |||
| public void stopClient() { | |||
| try { | |||
| binaryLogClient.disconnect(); | |||
| binaryLogClient.unregisterEventListener(this); | |||
There was a problem hiding this comment.
Do we have a unit test for shutdown? Can you verify that this was called there? Also, we should verify in order.
InOrder inOrder = inOrder(binaryLogClient, binlogExecutorService);
inOrder.verify(binaryLogClient).disconnect();
inOrder.verify(binaryLogClient).disconnect());
inOrder.verify(binlogExecutorService).disconnect());
Signed-off-by: Hai Yan <oeyh@amazon.com>
san81
approved these changes
Sep 19, 2024
dlvenable
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug by deregistering event listener when binlog client is disconnected.
Issues Resolved
When receiving negative acknowledgment, RDS source plugin will disconnect binlog client and reconnect with latest checkpoint. When reconnected, however, the client cannot process events any more with this error:
java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.FutureTask@56c0293[Not completed, task = java.util.concurrent.Executors$RunnableAdapter@33d53db2[Wrapped task = org.opensearch.dataprepper.plugins.source.rds.stream.BinlogEventListener$$Lambda$3144/0x000000080161d578@db0faf8]] rejected from java.util.concurrent.ThreadPoolExecutor@53e18682[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 12717915]This is because the old event listener is still registered and accepting events but its executor pool has been shutdown.
Testing
Was able to reproduce the issue by setting ack always to negative and run an RDS source pipeline. Also verified the fix with the same setup.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.