Add alternate name for Plugin #4968
Merged
+85
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dinu John <86094133+dinujoh@users.noreply.github.com>
dinujoh
requested review from
chenqi0805,
engechas,
graytaylor0,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
graytaylor0
previously approved these changes
Sep 21, 2024
dlvenable
requested changes
Sep 21, 2024
...lugin-framework/src/main/java/org/opensearch/dataprepper/plugin/ClasspathPluginProvider.java
Outdated
Show resolved
Hide resolved
dlvenable
requested changes
Sep 21, 2024
...repper-api/src/main/java/org/opensearch/dataprepper/model/annotations/DataPrepperPlugin.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Dinu John <86094133+dinujoh@users.noreply.github.com>
Signed-off-by: Dinu John <86094133+dinujoh@users.noreply.github.com>
graytaylor0
approved these changes
Sep 21, 2024
|
Looks like the build is failing from a test in |
It might be flaky. Other java version build is succeeding. I will restart the test. |
dlvenable
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add alternate name for Plugin
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.