Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added documentation for select entries, map-to-list, and trucate processors. #6660
Added documentation for select entries, map-to-list, and trucate processors. #6660
Changes from 9 commits
eba0f77
4a1c1cf
7038330
53b4bce
d037519
30443c8
8bb36c9
230ce17
dfcbecf
c394dfa
a8ac14b
79f740f
0f061af
9c68116
3e858ad
e186870
f3a5b17
bc86d25
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 46 in _data-prepper/pipelines/configuration/buffers/kafka.md
GitHub Actions / style-job
Check failure on line 9 in _data-prepper/pipelines/configuration/processors/truncate.md
GitHub Actions / style-job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the last sentence, should "true" be in code font?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"For greater customization" is a bit vague (Customization of what? Why?). Can this sentence be rephrased as "You can define both values in the configuration in order to [what specifically the user can do by defining both values]."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Then" doesn't really work here because we haven't referenced any action, only that the event contains keys with string values. I'd also prefer that we don't introduce the list with an incomplete sentence ending with "in which".