Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatibility page #7821

Merged
merged 16 commits into from
Jul 30, 2024
Merged

Add compatibility page #7821

merged 16 commits into from
Jul 30, 2024

Conversation

Naarcha-AWS
Copy link
Collaborator

Replaces PR #7287

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress release-notes PR: Include this PR in the automated release notes v2.16.0 labels Jul 23, 2024
@Naarcha-AWS Naarcha-AWS self-assigned this Jul 23, 2024
@github-actions GitHub Actions
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@Naarcha-AWS Naarcha-AWS changed the title Peterzhuamazon centos7 deprecation Add compatibility page Jul 23, 2024
@Naarcha-AWS Naarcha-AWS mentioned this pull request Jul 23, 2024
Closed
1 task
@Naarcha-AWS
Fix links
6be2a62 
Signed-off-by: Archer <naarcha@amazon.com>
@Naarcha-AWS Naarcha-AWS added 3 - Tech review PR: Tech review in progress and removed 5 - Editorial review PR: Editorial review in progress labels Jul 23, 2024
@Naarcha-AWS
Apply suggestions from code review
661cd7d 
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
@Naarcha-AWS
Apply suggestions from code review
9b79243 
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
@Naarcha-AWS
Copy link
Collaborator Author

@peterzhuamazon: Let me know if that covers everything.

@peterzhuamazon
Copy link
Member

@peterzhuamazon: Let me know if that covers everything.

I have no issues apart from the typo pointed out by @hdhalter .

If I see anything later I will just issue a PR.

Thanks @Naarcha-AWS !

@hdhalter hdhalter added 4 - Doc review PR: Doc review in progress 5 - Editorial review PR: Editorial review in progress and removed 3 - Tech review PR: Tech review in progress 4 - Doc review PR: Doc review in progress labels Jul 29, 2024
@Naarcha-AWS @hdhalter
Update _install-and-configure/install-opensearch/index.md
29b2fb4 
Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
natebower
natebower requested changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naarcha-AWS Please see my comments and changes and tag me for approval once addressed.

_install-and-configure/install-opensearch/index.md Outdated Show resolved Hide resolved
_install-and-configure/os-comp.md Outdated

## Supported operating systems

The following table lists the operating system versions that we are currently testing on:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"that we are currently testing on" => "that we are currently testing" or "that we currently support" (to match the heading)

_install-and-configure/os-comp.md Outdated Show resolved Hide resolved
_install-and-configure/os-comp.md Outdated

| Date | Issue | PR | Details |
|:-----------|:-------|:-------|:--------------------------|
| 2024-07-23 | [opensearch-build Issue 4379](https://github.com/opensearch-project/opensearch-build/issues/4379) | [PR 7821](https://github.com/opensearch-project/documentation-website/pull/7821) | Remove CentOS7 as it if approaching [EOL](https://blog.centos.org/2023/04/end-dates-are-coming-for-centos-stream-8-and-centos-linux-7/) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct "as it if".

_install-and-configure/os-comp.md Outdated Show resolved Hide resolved
_install-and-configure/os-comp.md Outdated
|:-----------|:-------|:-------|:--------------------------|
| 2024-07-23 | [opensearch-build Issue 4379](https://github.com/opensearch-project/opensearch-build/issues/4379) | [PR 7821](https://github.com/opensearch-project/documentation-website/pull/7821) | Remove CentOS7 as it if approaching [EOL](https://blog.centos.org/2023/04/end-dates-are-coming-for-centos-stream-8-and-centos-linux-7/) |
| 2024-03-08 | [opensearch-build Issue 4573](https://github.com/opensearch-project/opensearch-build/issues/4573) | [PR 6637](https://github.com/opensearch-project/documentation-website/pull/6637) | Remove CentOS8, add Almalinux8/Rockylinux8, remove Ubuntu 16.04/18.04 as we currently only test on 20.04 |
| 2023-06-06 | [documentation-website Issue 4217](https://github.com/opensearch-project/documentation-website/issues/4217) | [PR 4218](https://github.com/opensearch-project/documentation-website/pull/4218) | Support Matrix Creation |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Support matrix creation" (sentence case)?

@Naarcha-AWS @natebower
Apply suggestions from code review
af08613 
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
natebower
natebower approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one change that I missed the first time (sorry 😄).

_install-and-configure/install-opensearch/index.md Outdated Show resolved Hide resolved
Naarcha-AWS and others added 2 commits July 30, 2024 14:31
@Naarcha-AWS @natebower
Update _install-and-configure/install-opensearch/index.md
064c9ac 
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
@Naarcha-AWS
Merge branch 'main' into peterzhuamazon-centos7-deprecation
0537854
@Naarcha-AWS Naarcha-AWS merged commit da34229 into main Jul 30, 2024
6 checks passed
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 5 - Editorial review PR: Editorial review in progress labels Aug 1, 2024
mingshl pushed a commit to mingshl/documentation-website that referenced this pull request Aug 2, 2024
@Naarcha-AWS @peterzhuamazon
@hdhalter @natebower @mingshl
Add compatibility page (opensearch-project#7821)
d3fd3cd 
* Adding OS matrix changelog and remove CentOS7 as it is approaching EOL

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Add new compatibility page

Signed-off-by: Archer <naarcha@amazon.com>

* Fix links

Signed-off-by: Archer <naarcha@amazon.com>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* Update _install-and-configure/install-opensearch/index.md

Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

* Update _install-and-configure/install-opensearch/index.md

Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>

---------

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Archer <naarcha@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Co-authored-by: Heather Halter <HDHALTER@AMAZON.COM>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterzhuamazon peterzhuamazon peterzhuamazon left review comments

@hdhalter hdhalter hdhalter left review comments

@natebower natebower natebower approved these changes

@kolchfa-aws kolchfa-aws Awaiting requested review from kolchfa-aws kolchfa-aws is a code owner

@vagimeli vagimeli Awaiting requested review from vagimeli vagimeli is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@stephen-crawford stephen-crawford Awaiting requested review from stephen-crawford stephen-crawford is a code owner

@epugh epugh Awaiting requested review from epugh epugh is a code owner

Assignees

@Naarcha-AWS Naarcha-AWS

Labels
3 - Done Issue is done/complete release-notes PR: Include this PR in the automated release notes v2.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Naarcha-AWS @peterzhuamazon @natebower @hdhalter