Update fuzzy.md #7842

svitlo · 2024-07-26T06:12:26Z

Corrected the name of the string metric used by default

Description

The string measure used by default is called Damerau-Levenshtein distance, because transitions are not allowed in the definition of Levenshtein distance.

Issues Resolved

No issues resolved

Version

All

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2024-07-26T06:12:38Z

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

svitlo · 2024-07-26T06:25:23Z

@hdhalter, now I am really ready for your doc review.

kolchfa-aws

Thank you, @svitlo! A couple of suggestions:

Please change line 17 to Damerau-Levenshtein as well.
Since there is a transpositions parameter to allow/disallow transpositions, I think we should include a sentence about the ability to disable transpositions and make it a true Levenshtein distance. Maybe on the same line 17?

svitlo · 2024-07-27T10:06:41Z

Please change line 17 to Damerau-Levenshtein as well.

Done

Since there is a transpositions parameter to allow/disallow transpositions, I think we should include a sentence about the ability to disable transpositions and make it a true Levenshtein distance. Maybe on the same line 17?

Agree. Done.

svitlo · 2024-07-27T10:10:18Z

@kolchfa-aws, could you please review my amendment.

svitlo · 2024-07-27T10:33:36Z

@kolchfa-aws, I corrected the line 17 one more time to not break the thought regarding the usage of the field 'max_expansions'.

Could you please review it.

kolchfa-aws

Thank you, @svitlo! One rewording suggestion. Also, please fix DCO.

_query-dsl/term/fuzzy.md

Corrected the name of the string metric used by default Signed-off-by: Tim <2527559+svitlo@users.noreply.github.com> Signed-off-by: svitlo <tsplahtii@rolf.ru>

svitlo · 2024-07-30T15:31:13Z

Also, please fix DCO.

@kolchfa-aws, fixed.

kolchfa-aws · 2024-07-30T15:50:46Z

@svitlo Looks like you've picked up a few extraneous commits along the way :) Please rebase and push again.

svitlo · 2024-07-30T16:03:42Z

Please rebase and push again.

Done.

Could you please check.

svitlo · 2024-07-30T16:04:22Z

@kolchfa-aws, ^

kolchfa-aws · 2024-07-30T16:08:21Z

Hmmmmm.... I can still see others' commits in this PR https://github.com/opensearch-project/documentation-website/pull/7842/commits

svitlo · 2024-07-30T16:12:34Z

@kolchfa-aws, how can I fix it?

kolchfa-aws · 2024-07-30T17:10:10Z

Try rebasing the last 10 commits on your branch against main using this guide https://docs.github.com/en/get-started/using-git/about-git-rebase (so start with running git rebase --interactive HEAD~10). Let me know if you need help.

…role of the field 'transpositions' Signed-off-by: svitlo <tsplahtii@rolf.ru>

…he field 'max_expansions' Signed-off-by: svitlo <tsplahtii@rolf.ru>

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Tim <2527559+svitlo@users.noreply.github.com> Signed-off-by: svitlo <tsplahtii@rolf.ru>

svitlo · 2024-07-30T17:21:47Z

@kolchfa-aws, I followed your recommendations.

kolchfa-aws · 2024-07-30T21:20:03Z

Awesome, thanks! 🚢

* Update fuzzy.md Corrected the name of the string metric used by default Signed-off-by: Tim <2527559+svitlo@users.noreply.github.com> Signed-off-by: svitlo <tsplahtii@rolf.ru> * correct the line 17 of fuzzy.md to clarify the distance name and the role of the field 'transpositions' Signed-off-by: svitlo <tsplahtii@rolf.ru> * correct the line 17 to not break the thought regarding the usage of the field 'max_expansions' Signed-off-by: svitlo <tsplahtii@rolf.ru> * Update _query-dsl/term/fuzzy.md Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Tim <2527559+svitlo@users.noreply.github.com> Signed-off-by: svitlo <tsplahtii@rolf.ru> --------- Signed-off-by: Tim <2527559+svitlo@users.noreply.github.com> Signed-off-by: svitlo <tsplahtii@rolf.ru> Co-authored-by: svitlo <tsplahtii@rolf.ru> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> (cherry picked from commit 3dcff57) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update fuzzy.md Corrected the name of the string metric used by default Signed-off-by: Tim <2527559+svitlo@users.noreply.github.com> Signed-off-by: svitlo <tsplahtii@rolf.ru> * correct the line 17 of fuzzy.md to clarify the distance name and the role of the field 'transpositions' Signed-off-by: svitlo <tsplahtii@rolf.ru> * correct the line 17 to not break the thought regarding the usage of the field 'max_expansions' Signed-off-by: svitlo <tsplahtii@rolf.ru> * Update _query-dsl/term/fuzzy.md Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Tim <2527559+svitlo@users.noreply.github.com> Signed-off-by: svitlo <tsplahtii@rolf.ru> --------- Signed-off-by: Tim <2527559+svitlo@users.noreply.github.com> Signed-off-by: svitlo <tsplahtii@rolf.ru> Co-authored-by: svitlo <tsplahtii@rolf.ru> Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com>

svitlo requested review from hdhalter, kolchfa-aws, Naarcha-AWS, vagimeli, AMoo-Miki, natebower, dlvenable, stephen-crawford and epugh as code owners July 26, 2024 06:12

github-actions bot assigned hdhalter Jul 26, 2024

hdhalter added 4 - Doc review PR: Doc review in progress backport 2.15 labels Jul 26, 2024

hdhalter assigned kolchfa-aws and unassigned hdhalter Jul 26, 2024

kolchfa-aws reviewed Jul 26, 2024

View reviewed changes

svitlo mentioned this pull request Jul 27, 2024

Update match.md #7849

Merged

1 task

kolchfa-aws approved these changes Jul 29, 2024

View reviewed changes

_query-dsl/term/fuzzy.md Outdated Show resolved Hide resolved

Update fuzzy.md

49933a3

Corrected the name of the string metric used by default Signed-off-by: Tim <2527559+svitlo@users.noreply.github.com> Signed-off-by: svitlo <tsplahtii@rolf.ru>

svitlo force-pushed the patch-1 branch from 5cc2512 to 085ac11 Compare July 30, 2024 15:30

svitlo and others added 3 commits July 30, 2024 20:17

correct the line 17 of fuzzy.md to clarify the distance name and the …

02c8ec6

…role of the field 'transpositions' Signed-off-by: svitlo <tsplahtii@rolf.ru>

correct the line 17 to not break the thought regarding the usage of t…

83b32b5

…he field 'max_expansions' Signed-off-by: svitlo <tsplahtii@rolf.ru>

Update _query-dsl/term/fuzzy.md

6ac0870

Co-authored-by: kolchfa-aws <105444904+kolchfa-aws@users.noreply.github.com> Signed-off-by: Tim <2527559+svitlo@users.noreply.github.com> Signed-off-by: svitlo <tsplahtii@rolf.ru>

svitlo force-pushed the patch-1 branch from 085ac11 to 6ac0870 Compare July 30, 2024 17:19

kolchfa-aws merged commit 3dcff57 into opensearch-project:main Jul 30, 2024
5 checks passed

opensearch-trigger-bot bot mentioned this pull request Jul 30, 2024

[Backport 2.15] Update fuzzy.md #7870

Merged

github-actions bot pushed a commit that referenced this pull request Jul 30, 2024

Update fuzzy.md (#7842) (#7870)

e55c20b

svitlo deleted the patch-1 branch July 31, 2024 15:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update fuzzy.md #7842

Update fuzzy.md #7842

svitlo commented Jul 26, 2024 •

edited

Loading

github-actions bot commented Jul 26, 2024

svitlo commented Jul 26, 2024

kolchfa-aws left a comment

svitlo commented Jul 27, 2024 •

edited

Loading

svitlo commented Jul 27, 2024

svitlo commented Jul 27, 2024 •

edited

Loading

kolchfa-aws left a comment

svitlo commented Jul 30, 2024

kolchfa-aws commented Jul 30, 2024

svitlo commented Jul 30, 2024 •

edited

Loading

svitlo commented Jul 30, 2024

kolchfa-aws commented Jul 30, 2024

svitlo commented Jul 30, 2024

kolchfa-aws commented Jul 30, 2024

svitlo commented Jul 30, 2024

kolchfa-aws commented Jul 30, 2024

Update fuzzy.md #7842

Update fuzzy.md #7842

Conversation

svitlo commented Jul 26, 2024 • edited Loading

Description

Issues Resolved

Version

Checklist

github-actions bot commented Jul 26, 2024

svitlo commented Jul 26, 2024

kolchfa-aws left a comment

Choose a reason for hiding this comment

svitlo commented Jul 27, 2024 • edited Loading

svitlo commented Jul 27, 2024

svitlo commented Jul 27, 2024 • edited Loading

kolchfa-aws left a comment

Choose a reason for hiding this comment

svitlo commented Jul 30, 2024

kolchfa-aws commented Jul 30, 2024

svitlo commented Jul 30, 2024 • edited Loading

svitlo commented Jul 30, 2024

kolchfa-aws commented Jul 30, 2024

svitlo commented Jul 30, 2024

kolchfa-aws commented Jul 30, 2024

svitlo commented Jul 30, 2024

kolchfa-aws commented Jul 30, 2024

svitlo commented Jul 26, 2024 •

edited

Loading

svitlo commented Jul 27, 2024 •

edited

Loading

svitlo commented Jul 27, 2024 •

edited

Loading

svitlo commented Jul 30, 2024 •

edited

Loading