Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support script score when doc value is disabled #1573

Merged
merged 4 commits into from
Mar 28, 2024

fix test

46e9883
Select commit
Loading
Failed to load commit list.
Merged

Support script score when doc value is disabled #1573

fix test
46e9883
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 28, 2024 in 0s

84.97% (target 70.00%)

View this Pull Request on Codecov

84.97% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 90.24390% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 84.97%. Comparing base (c861966) to head (46e9883).

Files Patch % Lines
...opensearch/knn/index/KNNVectorDVLeafFieldData.java 76.92% 2 Missing and 1 partial ⚠️
...opensearch/knn/index/KNNVectorScriptDocValues.java 96.42% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1573      +/-   ##
============================================
+ Coverage     84.96%   84.97%   +0.01%     
- Complexity     1366     1374       +8     
============================================
  Files           172      172              
  Lines          5566     5599      +33     
  Branches        546      553       +7     
============================================
+ Hits           4729     4758      +29     
- Misses          605      607       +2     
- Partials        232      234       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.