[Backport 2.x] Support script score when doc value is disabled (#1573) #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugmakerrrrrr
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei and
martin-gaievski
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #1587 +/- ##
============================================
+ Coverage 84.86% 84.95% +0.09%
- Complexity 1343 1353 +10
============================================
Files 167 167
Lines 5516 5549 +33
Branches 548 555 +7
============================================
+ Hits 4681 4714 +33
Misses 602 602
Partials 233 233 ☔ View full report in Codecov by Sentry. |
|
Will wait for 2.14 increment PR(#1574) to be merged before we can merge this PR. |
navneet1v
changed the title
navneet1v
previously approved these changes
Apr 3, 2024
|
@jmazanec15 can you look into this PR. Its a backport PR. wasn't merged because 2.x branch was not upgraded to 2.14 |
jmazanec15
previously approved these changes
Apr 3, 2024
|
@bugmakerrrrrr can you raise the PR again by resolving the conflicts. |
) * support script score when doc value is disabled Signed-off-by: panguixin <panguixin@bytedance.com> * add test Signed-off-by: panguixin <panguixin@bytedance.com> * apply review comments Signed-off-by: panguixin <panguixin@bytedance.com> * fix test Signed-off-by: panguixin <panguixin@bytedance.com> --------- Signed-off-by: panguixin <panguixin@bytedance.com> (cherry picked from commit 771c4b5)
bugmakerrrrrr
force-pushed
the
backport/backport-1573-to-2.x
branch
from
e2506c3
to
1dd8426
Compare
navneet1v
approved these changes
Apr 4, 2024
|
@jmazanec15 can you approve the code, so that code can be merged. |
jmazanec15
approved these changes
Apr 4, 2024
jmazanec15
pushed a commit
to jmazanec15/k-NN-1
that referenced
this pull request
May 7, 2024
) (opensearch-project#1587) * support script score when doc value is disabled Signed-off-by: panguixin <panguixin@bytedance.com> * add test Signed-off-by: panguixin <panguixin@bytedance.com> * apply review comments Signed-off-by: panguixin <panguixin@bytedance.com> * fix test Signed-off-by: panguixin <panguixin@bytedance.com> --------- Signed-off-by: panguixin <panguixin@bytedance.com> (cherry picked from commit 771c4b5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
backport 1573
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.