Adds Unit tests for NativeEngines990KnnVectorsWriter #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shatejas
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan and
luyuncheng
as code owners
shatejas
commented
Sep 12, 2024
navneet1v
reviewed
Sep 12, 2024
src/main/java/org/opensearch/knn/index/codec/KNN990Codec/KNN990QuantizationStateWriter.java
Outdated
Show resolved
Hide resolved
navneet1v
reviewed
Sep 12, 2024
src/main/java/org/opensearch/knn/index/codec/KNN990Codec/NativeEngines990KnnVectorsWriter.java
Show resolved
Hide resolved
|
Please rebase the code to fix the CIs. |
5 tasks
shatejas
force-pushed
the
native-writer-unit-test
branch
2 times, most recently
from
a533be6
to
b771a2a
Compare
Had to separate out the common code to make it easy to write tests Mocking was difficult to do with the functional interfaces and it was throwing NPE in the test especially with the mock of NativeIndexWriter. Signed-off-by: Tejas Shah <shatejas@amazon.com>
shatejas
force-pushed
the
native-writer-unit-test
branch
from
b771a2a
to
5a777a0
Compare
navneet1v
approved these changes
Sep 13, 2024
jmazanec15
approved these changes
Sep 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Had to separate out the common code to make it easy to write tests Mocking was difficult to do with the functional interfaces and it was throwing NPE in the test especially with the mock of NativeIndexWriter. Signed-off-by: Tejas Shah <shatejas@amazon.com> (cherry picked from commit 0df0613)
navneet1v
pushed a commit
that referenced
this pull request
Sep 14, 2024
Had to separate out the common code to make it easy to write tests Mocking was difficult to do with the functional interfaces and it was throwing NPE in the test especially with the mock of NativeIndexWriter. Signed-off-by: Tejas Shah <shatejas@amazon.com> (cherry picked from commit 0df0613) Co-authored-by: Tejas Shah <shatejas@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to separate out the common code in NativeEngines990KnnVectorsWriter to make it easy to write tests. Mocking was difficult to do with the functional interfaces and it was throwing NPE in the test especially with the mock of NativeIndexWriter::flush and NativeIndexWriter::merge where it wasn't able to recognize the mocked writer.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.