Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Fix native engine vector format test #2107

Merged
merged 1 commit into from
Sep 14, 2024
Merged

[Backport 2.x] Fix native engine vector format test #2107

merged 1 commit into from
Sep 14, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 8277bf0 from #2103

@VijayanB @github-actions
Fix native engine vector format test (#2103)
6b5830a 
Previosuly we were not creating hnsw file on segment flush for faiss engine.
After successfully integrating hnsw file creation, we forgot to update unit test.
Here, we will confirm that required files are being created based on field type.

Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
(cherry picked from commit 8277bf0)
@navneet1v navneet1v merged commit 7ff8dd0 into 2.x Sep 14, 2024
93 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navneet1v navneet1v navneet1v approved these changes

@VijayanB VijayanB VijayanB approved these changes

@heemin32 heemin32 Awaiting requested review from heemin32 heemin32 is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@jmazanec15 jmazanec15 Awaiting requested review from jmazanec15 jmazanec15 is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda is a code owner

@junqiu-lei junqiu-lei Awaiting requested review from junqiu-lei junqiu-lei is a code owner

@martin-gaievski martin-gaievski Awaiting requested review from martin-gaievski martin-gaievski is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan ryanbogan is a code owner

@luyuncheng luyuncheng Awaiting requested review from luyuncheng luyuncheng is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@navneet1v @VijayanB