Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds rescore parameter in neural search #885

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Adds rescore parameter in neural search #885

merged 1 commit into from
Sep 5, 2024

Conversation

shatejas
Copy link
Contributor

@shatejas shatejas commented Sep 4, 2024

This is required to enable rescoring for on disk mode indices

Description

Also fixes method parameters

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@shatejas
Adds rescore parameter in neural search
afdc8c3 
This is required to enable rescoring for on disk mode indices

Signed-off-by: Tejas Shah <shatejas@amazon.com>
@shatejas shatejas marked this pull request as ready for review September 5, 2024 00:02
jmazanec15
jmazanec15 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@jmazanec15 jmazanec15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might need to fix CHANGELOG to release notes. But that can be done separately as well

@navneet1v navneet1v added the backport 2.x Label will add auto workflow to backport PR to 2.x branch label Sep 5, 2024
@navneet1v navneet1v merged commit cd577d5 into opensearch-project:main Sep 5, 2024
69 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
@shatejas @github-actions
Adds rescore parameter in neural search (#885)
1328acb 
This is required to enable rescoring for on disk mode indices

Signed-off-by: Tejas Shah <shatejas@amazon.com>
(cherry picked from commit cd577d5)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 5, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
@shatejas @github-actions
Adds rescore parameter in neural search (#885)
fec45c0 
This is required to enable rescoring for on disk mode indices

Signed-off-by: Tejas Shah <shatejas@amazon.com>
(cherry picked from commit cd577d5)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 5, 2024
Merged
naveentatikonda pushed a commit that referenced this pull request Sep 5, 2024
@opensearch-trigger-bot @shatejas
Adds rescore parameter in neural search (#885) (#888)
914898a 
This is required to enable rescoring for on disk mode indices

Signed-off-by: Tejas Shah <shatejas@amazon.com>
(cherry picked from commit cd577d5)

Co-authored-by: Tejas Shah <shatejas@amazon.com>
naveentatikonda pushed a commit that referenced this pull request Sep 5, 2024
@opensearch-trigger-bot @shatejas
Adds rescore parameter in neural search (#885) (#886)
cb01d69 
This is required to enable rescoring for on disk mode indices

Signed-off-by: Tejas Shah <shatejas@amazon.com>
(cherry picked from commit cd577d5)

Co-authored-by: Tejas Shah <shatejas@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navneet1v navneet1v navneet1v approved these changes

@jmazanec15 jmazanec15 jmazanec15 approved these changes

@heemin32 heemin32 Awaiting requested review from heemin32 heemin32 is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda is a code owner

@junqiu-lei junqiu-lei Awaiting requested review from junqiu-lei junqiu-lei is a code owner

@martin-gaievski martin-gaievski Awaiting requested review from martin-gaievski martin-gaievski is a code owner

@sean-zheng-amazon sean-zheng-amazon Awaiting requested review from sean-zheng-amazon sean-zheng-amazon is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn ylwu-amzn is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@vibrantvarun vibrantvarun Awaiting requested review from vibrantvarun vibrantvarun is a code owner

@zhichao-aws zhichao-aws Awaiting requested review from zhichao-aws zhichao-aws is a code owner

Assignees
No one assigned
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch backport 2.17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shatejas @navneet1v @jmazanec15 @naveentatikonda