Remove ability to skip stories in tests. #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
harshavamsi,
sachetalva,
nhtruong,
Xtansia,
VachaShah,
Tokesh and
aabeshov
as code owners
Signed-off-by: dblock <dblock@amazon.com>
Changes AnalysisCommit SHA: 84a53cd API ChangesSummaryNO CHANGES ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/9619311822/artifacts/1626225968 API Coverage
|
nhtruong
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
It's just a feature that's present in many test frameworks. It's for WIP tests or turning off flaky tests while working on solutions to resolve the flaky tests. Since we're not building an app with interwoven components, the need for this feature is very small. I'm okay with removing it to avoid it being abused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Potentially controversial @nhtruong :)
I find the
skip: trueoption harmful. I fail to see when I'd want to use this. Either I run individual tests (supported with--tests) or the entire suite. Disabling a solo test story seems to be an invitation for skipping something that's flaky, for example. If I really want to disable one locally, I can just comment it out.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.