Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate titles and descriptions in info and schema objects. #463

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Aug 3, 2024

Description

Validates titles and descriptions in info and schema objects.

These aren't all descriptions, will look at generalizing and avoiding repetition, maybe in a separate PR if it's ok.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

github-actions bot commented Aug 3, 2024

Changes Analysis

Commit SHA: 4d91531
Comparing To SHA: 13a603c

API Changes

Summary

├─┬Paths
│ └─┬/_plugins/_transform/{id}/_stop
│   └─┬POST
│     └──[🔀] description (5968:20)
└─┬Components
  ├─┬_common:GeoHexCell
  │ └──[🔀] description (26863:20)
  ├─┬_common:UnitSeconds
  │ └──[🔀] description (28376:20)
  ├─┬_common:TimeOfDay
  │ └──[🔀] description (28301:20)
  ├─┬_common:DurationLarge
  │ └──[🔀] description (26685:20)
  ├─┬_common:Void
  │ └──[🔀] description (28394:20)
  ├─┬_common:GeoLocation
  │ └──[🔀] description (26882:20)
  ├─┬_common:MinimumShouldMatch
  │ └──[🔀] description (27222:20)
  ├─┬indices._common:IndexSettings
  │ └──[🔀] description (42330:20)
  ├─┬_common:GeoBounds
  │ └──[🔀] description (26819:20)
  ├─┬_common:GeoTile
  │ └──[🔀] description (26903:20)
  ├─┬indices._common:IndexTemplate
  │ └──[🔀] description (42574:20)
  ├─┬_common:UnitNanos
  │ └──[🔀] description (28373:20)
  ├─┬_common:NodeRoles
  │ └──[🔀] description (27303:20)
  ├─┬_common:UnitMillis
  │ └──[🔀] description (28370:20)
  └─┬_common.query_dsl:SimpleQueryStringFlags
    └──[🔀] description (36678:20)

Document Element Total Changes Breaking Changes
paths 1 0
components 15 0
  • Total Changes: 16
  • Modifications: 16

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10239896411/artifacts/1774255999

API Coverage

Before After Δ
Covered (%) 510 (49.95 %) 510 (49.95 %) 0 (0 %)
Uncovered (%) 511 (50.05 %) 511 (50.05 %) 0 (0 %)
Unknown 24 24 0

Copy link

github-actions bot commented Aug 3, 2024

Spec Test Coverage Analysis

Total Tested
534 118 (22.1 %)

@dblock dblock force-pushed the validate-description branch 2 times, most recently from 0957e01 to 4396c20 Compare August 4, 2024 22:55
Signed-off-by: dblock <dblock@amazon.com>
@dblock
Copy link
Member Author

dblock commented Aug 4, 2024

@nhtruong @Xtansia rebased, ready

@Xtansia Xtansia merged commit ac8659d into opensearch-project:main Aug 4, 2024
14 of 15 checks passed
@dblock dblock deleted the validate-description branch August 5, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants