Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete variations of /{index}/alias/{name} tests, add tests for HEAD, bulk, analyzers. #519

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Aug 20, 2024

Description

  • Added tests for HEAD /.
  • Complete alias tests in the correct files, added indices.exists_alias@404.
  • Added more helpful info on using coverage reports.
  • Added tests for PUT /_bulk and /{index}/_bulk.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
Copy link

github-actions bot commented Aug 20, 2024

Changes Analysis

Commit SHA: ab1bedf
Comparing To SHA: ceefc37

API Changes

Summary

├─┬Paths
│ ├─┬/{index}/_alias/{name}
│ │ ├─┬GET
│ │ │ └─┬Responses
│ │ │   └──[➕] codes (25761:7)
│ │ └─┬HEAD
│ │   └─┬Responses
│ │     └──[➕] codes (25721:7)
│ ├─┬/{index}/_alias
│ │ └─┬GET
│ │   └─┬Responses
│ │     └──[➕] codes (25761:7)
│ ├─┬/_alias/{name}
│ │ ├─┬GET
│ │ │ └─┬Responses
│ │ │   └──[➕] codes (25761:7)
│ │ └─┬HEAD
│ │   └─┬Responses
│ │     └──[➕] codes (25721:7)
│ └─┬/_alias
│   └─┬GET
│     └─┬Responses
│       └──[➕] codes (25761:7)
└─┬Components
  ├──[➕] responses (25761:7)
  └──[➕] responses (25721:7)

Document Element Total Changes Breaking Changes
paths 6 0
components 2 0
  • Total Changes: 8
  • Additions: 8

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10491086295/artifacts/1837544646

API Coverage

Before After Δ
Covered (%) 524 (51.32 %) 524 (51.32 %) 0 (0 %)
Uncovered (%) 497 (48.68 %) 497 (48.68 %) 0 (0 %)
Unknown 26 26 0

Copy link

github-actions bot commented Aug 20, 2024

Spec Test Coverage Analysis

Total Tested
550 351 (63.82 %)

@dblock dblock force-pushed the add-tests branch 3 times, most recently from 6c40013 to d89e90b Compare August 21, 2024 12:36
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock removed the skip-changelog No need to update CHANGELOG. label Aug 21, 2024
@dblock dblock changed the title Cleanup alias tests & misc. Complete variations of /{index}/alias/{name} tests. Aug 21, 2024
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock changed the title Complete variations of /{index}/alias/{name} tests. Complete variations of /{index}/alias/{name} tests, add tests for HEAD, bulk, analyzers. Aug 21, 2024
Signed-off-by: dblock <dblock@amazon.com>
@@ -2455,6 +2470,9 @@ components:
type: object
additionalProperties:
$ref: '../schemas/indices.get_alias.yaml#/components/schemas/IndexAliases'
indices.get_alias@404:
content:
application/json: {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the schema for application/json is not defined, does that mean we don't care what it is, or it's an empty JSON, or a null for body?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's actually a schema, but I am deferring this to #445 if that's ok.

@dblock dblock requested a review from nhtruong August 21, 2024 17:31
@nhtruong nhtruong merged commit 772b1c8 into opensearch-project:main Aug 21, 2024
16 checks passed
@dblock dblock deleted the add-tests branch August 21, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants