Fix: evaluate output values before schema checking. #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
harshavamsi,
sachetalva,
nhtruong,
Xtansia,
VachaShah,
Tokesh and
aabeshov
as code owners
dblock
commented
Aug 27, 2024
| 'skipped/semver', | ||
| 'skipped/distributions/chapters', | ||
| 'skipped/distributions/excluded', | ||
| 'skipped/distributions/included' | ||
| ].map((fixture) => { return load_expected_evaluation(fixture, true) }) | ||
|
|
||
| expect(actual_evaluations).toStrictEqual(expected_evaluations) | ||
| expect(actual_evaluations).toEqual(expected_evaluations) |
There was a problem hiding this comment.
This is because of this:
@@ -959,11 +959,11 @@
"title": "DELETE /movies",
},
],
"prologues": Array [
Object {
- "output": Object {
+ "output": ChapterOutput {
"outputs": Object {
"boolean": false,
},
},
"overall": Object {
Changes AnalysisCommit SHA: 0845299 API ChangesSummaryNO CHANGES ReportThe full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10600394914/artifacts/1865747282 API Coverage
|
Spec Test Coverage Analysis
|
Xtansia
previously approved these changes
Aug 27, 2024
Signed-off-by: dblock <dblock@amazon.com>
dblock
force-pushed
the
fix-value-types
branch
from
60a0664
to
0845299
Compare
Xtansia
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracted from #524, fixing evaluating output values before schema checking for parameters and payload body. Otherwise if you reuse a value that's not a string type you get a type error during checking.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.