Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separated merger and tester fixtures, fixed leftoever nulls. #559

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Sep 9, 2024

Description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

github-actions bot commented Sep 9, 2024

Changes Analysis

Commit SHA: cf2ac23
Comparing To SHA: d279f4a

API Changes

Summary

└─┬Components
  ├─┬_common.mapping:XyShapeProperty
  │ └─┬Extensions
  │   └──[➕] x-version-added (36910:24)
  ├─┬_common:XyLocation
  │ └─┬Extensions
  │   └──[🔀] x-version-added (30258:24)
  ├─┬_common.mapping:XyPointProperty
  │ └─┬Extensions
  │   └──[➕] x-version-added (36892:24)
  └─┬_common.query_dsl:XyShapeQuery
    └─┬Extensions
      └──[🔀] x-version-added (38925:24)

Document Element Total Changes Breaking Changes
components 4 0
  • Total Changes: 4
  • Modifications: 2
  • Additions: 2

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10777177076/artifacts/1910038221

API Coverage

Before After Δ
Covered (%) 537 (52.6 %) 537 (52.6 %) 0 (0 %)
Uncovered (%) 484 (47.4 %) 484 (47.4 %) 0 (0 %)
Unknown 26 26 0

@dblock dblock changed the title Separated merger and tester fixtures. Separated merger and tester fixtures, fixed leftoever nulls. Sep 9, 2024
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
@dblock
Copy link
Member Author

dblock commented Sep 9, 2024

@kolchfa-aws I re-added x-version-added: 2.4 for the types you've added in this PR here.

Copy link

github-actions bot commented Sep 9, 2024

Spec Test Coverage Analysis

Total Tested
563 271 (48.13 %)

@Xtansia Xtansia merged commit 29185f4 into opensearch-project:main Sep 9, 2024
19 checks passed
@dblock dblock deleted the test-fixtures branch September 9, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No need to update CHANGELOG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] merge for a specific version nullifies refs in an array
2 participants