Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix geo distance query and its test #560

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

kolchfa-aws
Copy link
Contributor

This PR addresses the following issues for the geo_distance query spec and test:

  • Uses additionalProperties instead of hard-coding the field because the field name can be anything
  • Specifies that the field must be of the geo_point type
  • Moves the geo_distance query test into the query folder
  • Renames the index and field within the test to go along with the movie theme

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Copy link

github-actions bot commented Sep 9, 2024

Changes Analysis

Commit SHA: 0524078
Comparing To SHA: 5cd57c4

API Changes

Summary

└─┬Components
  └─┬_common.query_dsl:GeoDistanceQuery
    └─┬ALLOF
      ├──[➕] additionalProperties (37320:13)❌ 
      ├──[➖] required (37323:15)❌ 
      ├──[➕] minProperties (37321:26)❌ 
      └──[➖] properties (37319:13)❌ 

Document Element Total Changes Breaking Changes
components 4 8
  • BREAKING Changes: 8 out of 4
  • Removals: 2
  • Additions: 2
  • Breaking Removals: 2
  • Breaking Additions: 2

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10776511217/artifacts/1909829734

API Coverage

Before After Δ
Covered (%) 537 (52.6 %) 537 (52.6 %) 0 (0 %)
Uncovered (%) 484 (47.4 %) 484 (47.4 %) 0 (0 %)
Unknown 26 26 0

Signed-off-by: Fanit Kolchina <kolchfa@amazon.com>
Copy link

github-actions bot commented Sep 9, 2024

Spec Test Coverage Analysis

Total Tested
563 271 (48.13 %)

dblock
dblock previously approved these changes Sep 9, 2024
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase?

Signed-off-by: Theo N. Truong <theotr@amazon.com>
@nhtruong nhtruong merged commit d279f4a into opensearch-project:main Sep 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants