Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Input Manifest for 1.0 maven release. #307

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Aug 24, 2021

Signed-off-by: Marc Handalian handalm@amazon.com

Description

This PR creates a small input manifest to push 1.0 artifacts to maven for the repo's included.
Going forward this will be part of the full bundle release workflow, but for 1.0.0 we do not have solid 1.0 refs for all repos nor do we need to rebuild the full bundle.

Issues Resolved

One of the remaining steps for #20.
This will need to be set up in CI @bbarani and run as part of this jenkins job to build the artifacts.
The next step is to promote with this job.

Check List

  • [ x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Copy link
Member

dblock commented Aug 24, 2021

Should we call this -maven to make it clearer rather than -partial?

Add this information to https://github.com/opensearch-project/opensearch-build/blob/main/bundle-workflow/README.md#opensearch-bundle-workflow. Maybe link the versions to the manifests from that README?

Signed-off-by: Marc Handalian <handalm@amazon.com>
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We/you/someone can also write a unit test that ensures that the manifest loads from Python code.

build:
name: OpenSearch
version: 1.0.0
components:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is alerting notification also required by any plugin as dependency? We used to publish that too. Just confirming

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dblock we would also want alerting/notification, if we are publishing these to maven. Consumed by Index Management 1.0.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I don't see any artifacts copied in their build script, but they are pushed to maven local.

https://github.com/opensearch-project/opensearch-build/blob/main/bundle-workflow/scripts/components/alerting/build.sh#L71

Lets take this as a follow up, I don't want to hold the others while this gets sorted out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who is following up on this? ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working on this right now

@mch2 mch2 merged commit feaf980 into opensearch-project:main Aug 25, 2021
@mch2 mch2 deleted the 1.0maven branch August 25, 2021 19:16
@dblock dblock mentioned this pull request Aug 25, 2021
1 task
alborotogarcia pushed a commit to alborotogarcia/opensearch-build that referenced this pull request Sep 7, 2021
Signed-off-by: Marc Handalian <handalm@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants