Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests for common-utils. #807

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Oct 26, 2021

Signed-off-by: dblock dblock@amazon.com

Description

Skip running common-utils tests in distribution assembly.

Issues Resolved

Workaround for common-utils unit tests failing on Windows, which is opensearch-project/common-utils#85.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

Merging #807 (bea1592) into main (6bf406e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #807   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files          78       78           
  Lines        2164     2164           
=======================================
  Hits         1964     1964           
  Misses        200      200           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf406e...bea1592. Read the comment docs.

@dblock dblock requested a review from gaiksaya October 26, 2021 10:13
@dblock dblock merged commit 894f07d into opensearch-project:main Oct 26, 2021
@dblock dblock deleted the common-utils-x-test branch October 26, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants