feat: remove snapshot_spec and duplicate commands #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: suzhou <suzhou@amazon.com>
SuZhou-Joe
force-pushed
the
feature/index-management-2.5
branch
from
19b6f29
to
d93975b
Compare
SuZhou-Joe
changed the title
kavilla
reviewed
Jan 18, 2023
Signed-off-by: suzhou <suzhou@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
The root cause is that IM plugin add a commands named |
|
Add result log of the PR: IM logs |
|
According to the log above, the |
|
@SuZhou-Joe linting has issue it seems like. |
Yeah just checked by removing the |
Yeah seems like multiple files (not just the IM plugin tests having linting issues). Do you mind cleaning them up here? |
|
Will some of the changes from the original PR and this PR make it into the main branch as well? |
I think this feature is only in 2.x branch right now, if I remember correctly as they start developing on 2.x not main, correct me if I am mistaken here. Thanks. |
The lint checking seemed to be caused by SR plugin, not IM, seems in a previous PR didnt clean up. |
I think @SuZhou-Joe mentioned yesterday that he removed the snapshot test. |
kavilla
approved these changes
Jan 18, 2023
peterzhuamazon
approved these changes
Jan 18, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 18, 2023
* feat: remove snapshot spec and update commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: make actions to run again Signed-off-by: suzhou <suzhou@amazon.com> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <suzhou@amazon.com> Signed-off-by: suzhou <suzhou@amazon.com> (cherry picked from commit 900c8b0)
|
Related to opensearch-project/opensearch-build#2908 |
peterzhuamazon
pushed a commit
that referenced
this pull request
Jan 18, 2023
* feat: remove snapshot spec and update commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: make actions to run again Signed-off-by: suzhou <suzhou@amazon.com> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <suzhou@amazon.com> Signed-off-by: suzhou <suzhou@amazon.com> (cherry picked from commit 900c8b0) Co-authored-by: suzhou <suzhou@amazon.com>
47 tasks
SuZhou-Joe
added a commit
to SuZhou-Joe/opensearch-dashboards-functional-test
that referenced
this pull request
Feb 11, 2023
…#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: make actions to run again Signed-off-by: suzhou <suzhou@amazon.com> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <suzhou@amazon.com> Signed-off-by: suzhou <suzhou@amazon.com>
SuZhou-Joe
added a commit
that referenced
this pull request
Feb 15, 2023
* feat: add function test for IM plugin on v2.5 Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove snapshot_spec Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove duplicate commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove duplicate commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove some useless test case Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove snapshot_spec and duplicate commands (#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: make actions to run again Signed-off-by: suzhou <suzhou@amazon.com> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <suzhou@amazon.com> Signed-off-by: suzhou <suzhou@amazon.com> * feat: lint Signed-off-by: suzhou <suzhou@amazon.com> * feat: fix workflow bug Signed-off-by: suzhou <suzhou@amazon.com> * feat: use 2.5.0 version Signed-off-by: suzhou <suzhou@amazon.com> * feat: revert version to 3.0.0 Signed-off-by: suzhou <suzhou@amazon.com> --------- Signed-off-by: suzhou <suzhou@amazon.com>
SuZhou-Joe
added a commit
to SuZhou-Joe/opensearch-dashboards-functional-test
that referenced
this pull request
Feb 16, 2023
* feat: add function test for IM plugin on v2.5 Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove snapshot_spec Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove duplicate commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove duplicate commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove some useless test case Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove snapshot_spec and duplicate commands (opensearch-project#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: make actions to run again Signed-off-by: suzhou <suzhou@amazon.com> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <suzhou@amazon.com> Signed-off-by: suzhou <suzhou@amazon.com> * feat: lint Signed-off-by: suzhou <suzhou@amazon.com> * feat: fix workflow bug Signed-off-by: suzhou <suzhou@amazon.com> * feat: use 2.5.0 version Signed-off-by: suzhou <suzhou@amazon.com> * feat: revert version to 3.0.0 Signed-off-by: suzhou <suzhou@amazon.com> --------- Signed-off-by: suzhou <suzhou@amazon.com> (cherry picked from commit 95edebc)
1 task
SuZhou-Joe
added a commit
to SuZhou-Joe/opensearch-dashboards-functional-test
that referenced
this pull request
Feb 16, 2023
* feat: add function test for IM plugin on v2.5 Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove snapshot_spec Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove duplicate commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove duplicate commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove some useless test case Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove snapshot_spec and duplicate commands (opensearch-project#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: make actions to run again Signed-off-by: suzhou <suzhou@amazon.com> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <suzhou@amazon.com> Signed-off-by: suzhou <suzhou@amazon.com> * feat: lint Signed-off-by: suzhou <suzhou@amazon.com> * feat: fix workflow bug Signed-off-by: suzhou <suzhou@amazon.com> * feat: use 2.5.0 version Signed-off-by: suzhou <suzhou@amazon.com> * feat: revert version to 3.0.0 Signed-off-by: suzhou <suzhou@amazon.com> --------- Signed-off-by: suzhou <suzhou@amazon.com> (cherry picked from commit 95edebc)
1 task
CCongWang
pushed a commit
that referenced
this pull request
Feb 16, 2023
* feat: add function test for IM plugin on v2.5 Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove snapshot_spec Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove duplicate commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove duplicate commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove some useless test case Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove snapshot_spec and duplicate commands (#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: make actions to run again Signed-off-by: suzhou <suzhou@amazon.com> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <suzhou@amazon.com> Signed-off-by: suzhou <suzhou@amazon.com> * feat: lint Signed-off-by: suzhou <suzhou@amazon.com> * feat: fix workflow bug Signed-off-by: suzhou <suzhou@amazon.com> * feat: use 2.5.0 version Signed-off-by: suzhou <suzhou@amazon.com> * feat: revert version to 3.0.0 Signed-off-by: suzhou <suzhou@amazon.com> --------- Signed-off-by: suzhou <suzhou@amazon.com> (cherry picked from commit 95edebc)
CCongWang
pushed a commit
that referenced
this pull request
Feb 16, 2023
* feat: add function test for IM plugin on v2.5 Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove snapshot_spec Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove duplicate commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove duplicate commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove some useless test case Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove snapshot_spec and duplicate commands (#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: make actions to run again Signed-off-by: suzhou <suzhou@amazon.com> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <suzhou@amazon.com> Signed-off-by: suzhou <suzhou@amazon.com> * feat: lint Signed-off-by: suzhou <suzhou@amazon.com> * feat: fix workflow bug Signed-off-by: suzhou <suzhou@amazon.com> * feat: use 2.5.0 version Signed-off-by: suzhou <suzhou@amazon.com> * feat: revert version to 3.0.0 Signed-off-by: suzhou <suzhou@amazon.com> --------- Signed-off-by: suzhou <suzhou@amazon.com> (cherry picked from commit 95edebc)
sebastianmichalski
pushed a commit
to sebastianmichalski/opensearch-dashboards-functional-test
that referenced
this pull request
Mar 24, 2023
…#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: make actions to run again Signed-off-by: suzhou <suzhou@amazon.com> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <suzhou@amazon.com> Signed-off-by: suzhou <suzhou@amazon.com>
sebastianmichalski
added a commit
to sebastianmichalski/opensearch-dashboards-functional-test
that referenced
this pull request
Mar 24, 2023
…-project#450)" This reverts commit a797af9.
jakubp-eliatra
pushed a commit
to sebastianmichalski/opensearch-dashboards-functional-test
that referenced
this pull request
Mar 24, 2023
* feat: add function test for IM plugin on v2.5 Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove snapshot_spec Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove duplicate commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove duplicate commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove some useless test case Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove snapshot_spec and duplicate commands (opensearch-project#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: make actions to run again Signed-off-by: suzhou <suzhou@amazon.com> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <suzhou@amazon.com> Signed-off-by: suzhou <suzhou@amazon.com> * feat: lint Signed-off-by: suzhou <suzhou@amazon.com> * feat: fix workflow bug Signed-off-by: suzhou <suzhou@amazon.com> * feat: use 2.5.0 version Signed-off-by: suzhou <suzhou@amazon.com> * feat: revert version to 3.0.0 Signed-off-by: suzhou <suzhou@amazon.com> --------- Signed-off-by: suzhou <suzhou@amazon.com> Signed-off-by: Jakub Przybylski <jakub.przybylski@eliatra.com>
leanneeliatra
pushed a commit
to leanneeliatra/opensearch-dashboards-functional-test-fork
that referenced
this pull request
Sep 15, 2023
…#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: make actions to run again Signed-off-by: suzhou <suzhou@amazon.com> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <suzhou@amazon.com> Signed-off-by: suzhou <suzhou@amazon.com> Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
leanneeliatra
pushed a commit
to leanneeliatra/opensearch-dashboards-functional-test-fork
that referenced
this pull request
Sep 15, 2023
…earch-project#536) * feat: add function test for IM plugin on v2.5 Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove snapshot_spec Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove duplicate commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove duplicate commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove some useless test case Signed-off-by: suzhou <suzhou@amazon.com> * feat: remove snapshot_spec and duplicate commands (opensearch-project#450) * feat: remove snapshot spec and update commands Signed-off-by: suzhou <suzhou@amazon.com> * feat: make actions to run again Signed-off-by: suzhou <suzhou@amazon.com> * feat: change to addIndexAlias & removeIndexAlias Signed-off-by: suzhou <suzhou@amazon.com> Signed-off-by: suzhou <suzhou@amazon.com> * feat: lint Signed-off-by: suzhou <suzhou@amazon.com> * feat: fix workflow bug Signed-off-by: suzhou <suzhou@amazon.com> * feat: use 2.5.0 version Signed-off-by: suzhou <suzhou@amazon.com> * feat: revert version to 3.0.0 Signed-off-by: suzhou <suzhou@amazon.com> --------- Signed-off-by: suzhou <suzhou@amazon.com> (cherry picked from commit 95edebc) Signed-off-by: leanne.laceybyrne@eliatra.com <leanne.laceybyrne@eliatra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: suzhou suzhou@amazon.com
Description
The snapshot spec is no long needed in IM plugin and blocked the E2E test in this repo.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.