Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Generator #872

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

nhtruong
Copy link
Collaborator

Program to generate and update OpenSearch JS Client with the newest from the OpenSearch OpenAPI Spec.

Issues Resolved

Closes #789

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only did a cursory look of the generator code itself. Great work!

@dblock
Copy link
Member

dblock commented Sep 13, 2024

Take a pass at DEVELOPER_GUIDE and such as well.

@nhtruong
Copy link
Collaborator Author

Not sure why it keeps saying there's an error on line 52 of the generate_api workflow 🤔
https://github.com/opensearch-project/opensearch-js/actions/runs/10853677637/workflow

@dblock
Copy link
Member

dblock commented Sep 14, 2024

generate_api

VSCode says the title is not properly quoted (and installation_id is not a parameter to tibdex/github-app-token@v2.1.0, but that's above).

Signed-off-by: Theo Truong <theotr@amazon.com>
@nhtruong nhtruong merged commit 0bde007 into opensearch-project:main Sep 16, 2024
53 of 55 checks passed
@nhtruong nhtruong deleted the client_generator_3.0 branch September 16, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Generate API code from OpenSearch API Spec
2 participants