-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): attempt dotnet format #744
Draft
joefeser
wants to merge
9
commits into
opensearch-project:main
Choose a base branch
from
joefeser:feat/editorconfig-attempt-dotnet-format
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(): attempt dotnet format #744
joefeser
wants to merge
9
commits into
opensearch-project:main
from
joefeser:feat/editorconfig-attempt-dotnet-format
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joefeser
requested review from
anirudha,
dblock,
joshuali925,
Xtansia,
VachaShah,
MaxKsyunz and
Yury-Fridlyand
as code owners
August 6, 2024 18:02
joefeser
force-pushed
the
feat/editorconfig-attempt-dotnet-format
branch
3 times, most recently
from
August 8, 2024 01:09
1e67334
to
d9b92e0
Compare
Signed-off-by: Joe Feser <joseph.feser@gmail.com>
Signed-off-by: Joe Feser <joseph.feser@gmail.com>
Signed-off-by: Joe Feser <joseph.feser@gmail.com>
Signed-off-by: Joe Feser <joseph.feser@gmail.com>
Signed-off-by: Joe Feser <joseph.feser@gmail.com>
joefeser
force-pushed
the
feat/editorconfig-attempt-dotnet-format
branch
from
August 8, 2024 02:53
d9b92e0
to
8f23c3b
Compare
Signed-off-by: Joe Feser <joseph.feser@gmail.com>
joefeser
force-pushed
the
feat/editorconfig-attempt-dotnet-format
branch
from
August 10, 2024 01:05
8f23c3b
to
185b712
Compare
Signed-off-by: Joe Feser <joseph.feser@gmail.com>
Signed-off-by: Joe Feser <joseph.feser@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
running dotnet format based on .editorconfig
Issues Resolved
Results of the conversation in #739
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.